Add encapsulated-plugin compatibility for Zen Cart 2.2.1#59
Open
Iscarly-Mr wants to merge 1 commit intolat9:masterfrom
Open
Add encapsulated-plugin compatibility for Zen Cart 2.2.1#59Iscarly-Mr wants to merge 1 commit intolat9:masterfrom
Iscarly-Mr wants to merge 1 commit intolat9:masterfrom
Conversation
Owner
|
I'm sorry, but while I applaud your efforts I can't accept this change as it's not a "proper" encapsulated plugin. When the SitemapXML "goes encapsulated", it will drop support for the unencapsulated/classic versions and make modifications to its distribution to host all files in their |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds compatibility for using SitemapXML as an encapsulated plugin on Zen Cart 2.2.1 while retaining support for the classic installation layout.
Summary of changes:
header_php.php, loadsitemapxml.phpfrom the plugin-local classes directory when present, falling back to the classic core path otherwise.header_php.php, discoversitemapxml_*.phpgenerator modules from the plugin-local page directory first, then fall back to the classic core path.YOUR_Admin/sitemapxml.php, discover the available sitemap generator modules from the plugin-local directory first, then fall back to the classic core path.Why:
zc_plugins, the current v4.0.5 code still looks for the sitemap class and generator modules in the classic core locations. That leaves the admin generator list empty and prevents sitemap generation.Validation: