Skip to content

feat: add strict tool validation configuration to OpenAIAugmentedLLM #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add strict tool validation configuration to OpenAIAugmentedLLM #162

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1232f7
feat: add strict tool validation configuration to OpenAIAugmentedLLM
vanshb03 Apr 26, 2025
35bfe67
rem: TODO comment regarding default strict tool validation setting
vanshb03 Apr 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/mcp_agent/workflows/llm/augmented_llm_openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,14 @@ def __init__(self, *args, **kwargs):
if hasattr(self.context.config.openai, "reasoning_effort"):
self._reasoning_effort = self.context.config.openai.reasoning_effort

self._reasoning = lambda model : model.startswith(("o1","o3","o4"))
self._reasoning = lambda model: model.startswith(("o1", "o3", "o4"))

self._strict_tool_validation = True # default strict validation
if self.context and self.context.config and self.context.config.openai:
if hasattr(self.context.config.openai, "strict_tool_validation"):
self._strict_tool_validation = (
self.context.config.openai.strict_tool_validation
)

if self._reasoning(chosen_model):
self.logger.info(
Expand Down Expand Up @@ -142,7 +149,7 @@ async def generate(self, message, request_params: RequestParams | None = None):
"name": tool.name,
"description": tool.description,
"parameters": tool.inputSchema,
# TODO: saqadri - determine if we should specify "strict" to True by default
"strict": self._strict_tool_validation,
},
)
for tool in response.tools
Expand All @@ -163,10 +170,8 @@ async def generate(self, message, request_params: RequestParams | None = None):
if self._reasoning(model):
arguments = {
**arguments,

# DEPRECATED: https://platform.openai.com/docs/api-reference/chat/create#chat-create-max_tokens
# "max_tokens": params.maxTokens,

"max_completion_tokens": params.maxTokens,
"reasoning_effort": self._reasoning_effort,
}
Expand Down
Loading