Merged
Conversation
Open
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the _convert_nans_to_fillval function where np.nan_to_num was being called incorrectly. The old code passed -1e31 as the second positional argument (which is the copy parameter), instead of using the named nan parameter. The fix properly uses nan=fill_value to replace NaN values in variable attributes with the appropriate fill value for each variable's data type.
Key Changes
- Corrected two calls to
np.nan_to_numto use the named parameternan=fill_valueinstead of incorrectly passing-1e31as a positional argument - Uses data-type-specific fill values (computed via
_dtype_to_fillval) instead of the hardcoded-1e31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.