Here are several fixes and some features #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lot as default value for some arguments.
…l objects or single id to underlying xmlrpc call.
…s __%s attribute ?
…have ``active`` field.
…with a default value.
It should be added this limit could not be removed easily due to the fact that providing 'None' or '0' was ignored due to the ``if int(limit)`` barrier.
Note that in python version < 2.7.9, this will fail if ``verify`` is ``True`` as by default, python library would NOT verify SSL certs. backporting the validation was not included in this version so it'll just fail with a hopefully clear error message. On version > 2.7.9, you can disable (or leave enabled) the verification.
This is an loading time optimization as ``pydot`` is only used in one function and that the import time of ``pydot`` is non neglectable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, could you consider merging this branch ?
I tried to separate clearly these fixes and features in several commit. Please remember that you can comment each of them individually, and would be glad to remove some of them if you wouldn't want to cherry-pick them. They are all quite independant.
Several commit comes from zikzakmedia branch as well. But several needed more attention and introduced new bug, so I went in to a thorough review of each of them. I would be glad to change anything that bothers you.
Notice that I've separated the Pyro code outside of this branch, as I'm trying to make everyone happy.
Individual commit are very small.
Thanks for considering this.