Fix: Fix PHPStan error by chaining Stringable methods for email+IP #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
$this->string('email')
returns aStringable
. In the old code we did:By using the
.
operator to append|{$this->ip()}
, theStringable
was immediately cast to a plain string. PHPStan complained because the concatenation happens without casting theStringable
object to string.Solution:
We now keep everything as a
Stringable
:This chains all transformations on the
Stringable
object and only converts to a string once, which satisfies PHPStan’s type checks.