Skip to content

Feature/show gates response message #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Geelik
Copy link
Contributor

@Geelik Geelik commented Mar 5, 2025

Telescope does not show the message if we use Response::allow or Response::deny inside gates or policies.
It allows better and easier debugging.

@taylorotwell
Copy link
Member

Please provide screenshots.

@taylorotwell taylorotwell marked this pull request as draft March 5, 2025 15:43
@Geelik
Copy link
Contributor Author

Geelik commented Mar 5, 2025

Screenshot 2025-03-05 at 16-57-54 Gates - Telescope
Screenshot 2025-03-05 at 16-58-16 Gate Details - Telescope
Screenshot 2025-03-05 at 16-58-43 Gate Details - Telescope

testbench.yaml Outdated
@@ -10,4 +10,3 @@ seeders:

workbench:
start: '/telescope'
user: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the seeder for the tests was deleted this prevented the use of testbench serve command.

@Geelik Geelik requested a review from crynobone June 5, 2025 08:46
@Geelik Geelik force-pushed the feature/show-gates-response-message branch from 2bd5721 to 2afaa39 Compare July 6, 2025 11:29
@Geelik Geelik marked this pull request as ready for review July 6, 2025 11:32
@taylorotwell taylorotwell merged commit fc0a866 into laravel:5.x Jul 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants