Skip to content

[13.x] Add #[\Override] to the BatchFake class methods #55358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

imanghafoori1
Copy link
Contributor

Marks the overridden methods with the proper PHP attribute.

@crynobone
Copy link
Member

crynobone commented Apr 10, 2025

illuminate/support doesn't require symfony/polyfill-php83 and this would cause an issue using the component outside of Laravel Framework on PHP 8.2

We selectively use #[\Override] on components that rely on external packages such as Symfony to handle breaking changes

@crynobone
Copy link
Member

Might be best to have this for master branch where we bump the minimum PHP versions to 8.3

@imanghafoori1 imanghafoori1 changed the base branch from 12.x to master April 10, 2025 15:36
@imanghafoori1
Copy link
Contributor Author

imanghafoori1 commented Apr 10, 2025

@crynobone Thanks for the clarification. The PR is now from master to master branch

@imanghafoori1 imanghafoori1 changed the title [12.x] Add #[\Override] to the BatchFake class methods [13.x] Add #[\Override] to the BatchFake class methods Apr 10, 2025
@taylorotwell taylorotwell merged commit 1c87360 into laravel:master Apr 11, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants