Fix presumed typo #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sentence does not really make sense to me, changing what I think is a typo makes it better, but I still don't fully understand what it's trying to say: "This component will add an Artisan `self-update` command to every built application." That makes it sound like all applications will get a self-update command, when I presume it is just the project the component is installed on? I could very well be misunderstanding something, but hopefully we can clear things up :)
owenvoke
approved these changes
Dec 12, 2023
|
Thanks for the typo fix. 👍🏻 It's basically just saying that all built applications (Phar packages) that include this component will have a Maybe just "your" instead of "every". 🤷🏻 |
I think that is great, I'll make the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sentence does not really make sense to me, changing what I think is a typo makes it better, but I still don't fully understand what it's trying to say: "This component will add an Artisan
self-updatecommand to every built application."That makes it sound like all applications will get a self-update command, when I presume it is just the project the component is installed on? I could very well be misunderstanding something, but hopefully we can clear things up :)