Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update strategy class names in standalone app docs #25

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Update strategy class names in standalone app docs #25

merged 1 commit into from
Apr 15, 2022

Conversation

calkeo
Copy link
Contributor

@calkeo calkeo commented Apr 15, 2022

The docs currently reference the class names for the self-update strategies as being GitHub and GitLab, whereas the class names in the framework are actually Github and Gitlab.

This PR fixes these class names in the docs.

owenvoke
owenvoke approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, that's a shame though. Technically they're the wrong capitalisation in the framework. 😬

@owenvoke owenvoke merged commit dd19708 into laravel-zero:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenvoke owenvoke owenvoke approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calkeo @owenvoke