Skip to content

Fixed deprecation notice for php 8.4 #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.0
Choose a base branch
from

Conversation

websmurf
Copy link

We are not ready for the upgrade to ORM 3.x yet, so this is a small fix for deprecations on php 8.4

@websmurf
Copy link
Author

I've had a look at the errors in phpstan, but they don't seem to be related to my change as far as I can tell.
What the correct procedure for this?

@TomHAnderson
Copy link
Contributor

You're right, they aren't related to your change. This is probably due to a fluid phpstan version. I'll look into them.

@TomHAnderson
Copy link
Contributor

This is the last CI run on the 2.0 branch:
https://github.com/laravel-doctrine/orm/actions/runs/11431449791
The logs have expired.

There are a couple things that could be done:

  • Fix the PHPStan issues
  • Remove PHPStan from this archaic 2.0 branch

I'm OK with either fix. But it must be noted that I came on to this project to build v3. I didn't take on the responsibility of the 2.0 branch. That being said, I'm very willing to work with contributors on any contributions to the 2.0 branch.

It would be helpful if anyone from the 2.0 team could chime in here with their view.

ignored phpstan errors
@websmurf
Copy link
Author

@TomHAnderson the errors from Console/DumpDatabaseCommand.php are currently in the baseline as well, so that's an easy fix. I'll just regenerate the baseline with the new phpstan error format :-)

The deprecation of Doctrine\Common\Proxy\Autoloader is known as well, and will be fixed in the 3.0 upgrade.
The convertToLaravelPaginator will have implications for users of laravel doctrine as well I think because it most likely will force users to hint them as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants