Koala: Adding SSL disabling ENV control (See #198)#199
Open
Koala: Adding SSL disabling ENV control (See #198)#199
Conversation
Collaborator
|
Please fix the ruff formatting issue. |
mikegros
requested changes
Mar 18, 2026
| cfg.set("DEFAULT", "favor_recall", "false") # be stricter; less noise | ||
| try: | ||
| # If you fetched HTML already, use extract() on string; otherwise, fetch_url(url) | ||
| downloaded = trafilatura.fetch_url(html, no_ssl=no_ssl) |
Collaborator
There was a problem hiding this comment.
I think this is incorrectly implemented. As ruff indicates, "downloaded" isnt used anywhere.
It's also not clear why you are trying to fetch again. The information passed into this function should be a string representation of the webpage, not a URL.
Can we just remove this line?
mikegros
reviewed
Mar 19, 2026
| from langchain_community.document_loaders import PyPDFLoader | ||
|
|
||
| # Optionally disable SSL for trafilatura | ||
| no_ssl = os.environ["URSA_DISABLE_SSL"] |
Collaborator
There was a problem hiding this comment.
I think you would actually want to use something like:
no_ssl = os.getenv("URSA_DISABLE_SSL")
As it is, this throws key errors in almost every test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #198, adding the
URSA_DISABLE_SSLENV var to allow disabling SSL for trafilatura. This helps URSA work correctly with SSL interception for the LAMMPS agent.