Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update setup of templates to consider component type #4523

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request updates the setup of templates to update components based on their type instead of the display name. It removes the display name to prevent overwriting the display name from the latest template. The code changes ensure that the latest template code is used for each component, and if the component type changes, the template type is also updated. Additionally, any outputs and prompt fields are updated accordingly. The pull request also removes fields that are not present in the latest template.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 12, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 12, 2024
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #4523 will degrade performances by 35.91%

Comparing updateExamplesFix (f488f2b) with main (f1fd5be)

Summary

❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main updateExamplesFix Change
test_successful_run_with_output_type_any 162.3 ms 253.2 ms -35.91%

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 13, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 13, 2024
- Added "Amazon Bedrock" to the list of model provider options in multiple JSON files.
- Updated the `AgentComponent` class to include `get_model_name` for retrieving the model name.
- Changed the `tools` field requirement to optional in several JSON files.
- Added a `legacy` field to the Blog Writer JSON configuration.
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 13, 2024
…nt, Hierarchical Tasks Agent, Memory Chatbot, Sequential Task Agent, Simple Agent, Travel Planning Agent, and Vector Store RAG
@ogabrielluiz ogabrielluiz merged commit 1cd21e5 into main Nov 13, 2024
5 checks passed
@ogabrielluiz ogabrielluiz deleted the updateExamplesFix branch November 13, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants