-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update setup of templates to consider component type #4523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
This PR changes 10-29 lines, ignoring generated files.
label
Nov 12, 2024
CodSpeed Performance ReportMerging #4523 will degrade performances by 35.91%Comparing Summary
Benchmarks breakdown
|
ogabrielluiz
force-pushed
the
updateExamplesFix
branch
from
November 12, 2024 16:28
62c7407
to
5ad833e
Compare
ogabrielluiz
approved these changes
Nov 13, 2024
ogabrielluiz
force-pushed
the
updateExamplesFix
branch
from
November 13, 2024 01:55
5ad833e
to
edd8a7f
Compare
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
and removed
size:S
This PR changes 10-29 lines, ignoring generated files.
labels
Nov 13, 2024
ogabrielluiz
force-pushed
the
updateExamplesFix
branch
from
November 13, 2024 02:39
0cac40f
to
4bcfc5d
Compare
…instead of the display name
ogabrielluiz
force-pushed
the
updateExamplesFix
branch
from
November 13, 2024 02:47
4bcfc5d
to
743d664
Compare
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
and removed
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Nov 13, 2024
- Added "Amazon Bedrock" to the list of model provider options in multiple JSON files. - Updated the `AgentComponent` class to include `get_model_name` for retrieving the model name. - Changed the `tools` field requirement to optional in several JSON files. - Added a `legacy` field to the Blog Writer JSON configuration.
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
and removed
size:S
This PR changes 10-29 lines, ignoring generated files.
labels
Nov 13, 2024
…nt, Hierarchical Tasks Agent, Memory Chatbot, Sequential Task Agent, Simple Agent, Travel Planning Agent, and Vector Store RAG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the setup of templates to update components based on their type instead of the display name. It removes the display name to prevent overwriting the display name from the latest template. The code changes ensure that the latest template code is used for each component, and if the component type changes, the template type is also updated. Additionally, any outputs and prompt fields are updated accordingly. The pull request also removes fields that are not present in the latest template.