unify the coding style of using testcontainers #48
Conversation
Thanks for reply, and I just checked #60 pull request，there're some files changed on both. What I did is let all series of vector dbs to use log instead of system out, for example, and both of use did unify the coding style on testcontainers. So, I can merge this PR if it approved before mine, with pleasure. Or vice versa, maybe :) |
|
@langchain4j Please take a quick look, there's no conflects |
| @@ -0,0 +1,8 @@ | |||
| #!/bin/bash | |||
| export JDK21_HOME=/usr/local/opt/openjdk/libexec/openjdk.jdk/Contents/Home | |||
There was a problem hiding this comment.
why is this required?
|
|
||
| <dependency> | ||
| <groupId>org.testcontainers</groupId> | ||
| <artifactId>elasticsearch</artifactId> |
There was a problem hiding this comment.
there is another elasticsearch dep with other version above
|
|
||
| <dependency> | ||
| <groupId>org.testcontainers</groupId> | ||
| <artifactId>neo4j</artifactId> |
There was a problem hiding this comment.
same here.
please double-check all your changes.
|
I just created a new PR, and let's move to #78. |
To unify the coding style of using testcontainers, and improve maturity for logging