-
Notifications
You must be signed in to change notification settings - Fork 19.8k
feat(model-profiles): distribute data across packages #34024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #34024 will not alter performanceComparing
|
| @model_validator(mode="after") | ||
| def _set_model_profile(self) -> Self: | ||
| """Set model profile if not overridden.""" | ||
| if not self.profile: | ||
| self.profile = MODEL_PROFILES.get(self.model) | ||
|
|
||
| return self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a field validator I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it needs to be a model validator because it relies on another field self.model for the lookup.
No description provided.