Skip to content

Conversation

@cbornet
Copy link
Collaborator

@cbornet cbornet commented Nov 14, 2025

Use of the fixture _base_vcr_config is deprecated with alternative function base_vcr_config()
This way:

  • we don't need to import _base_vcr_config seen as unused (which leads to PLC0414 and F811)
  • we don't need to make a copy since a new dict is created at each function invocation

@cbornet cbornet requested review from ccurme and mdrxy as code owners November 14, 2025 11:27
@github-actions github-actions bot added integration Related to a provider partner package integration langchain Related to the package `langchain` standard-tests Related to the package `standard-tests` anthropic groq openai refactor labels Nov 14, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 14, 2025

CodSpeed Performance Report

Merging #33968 will not alter performance

Comparing cbornet:base_vcr_config (4a54f3e) with master (275dcbf)

Summary

✅ 10 untouched
⏩ 24 skipped1

Footnotes

  1. 24 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

anthropic groq integration Related to a provider partner package integration langchain Related to the package `langchain` openai refactor standard-tests Related to the package `standard-tests`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant