Skip to content

docs: enhance Salesforce Toolkit documentation #31387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 2, 2025

Conversation

colesmcintosh
Copy link
Contributor

PR Title

docs: enhance Salesforce Toolkit documentation

PR Description

Description: Enhanced the Salesforce Toolkit documentation to provide a more comprehensive overview of the langchain-salesforce package. The updates include improved descriptions of the toolkit's capabilities, detailed setup instructions for authentication using environment variables, updated code snippets with consistent parameter naming and improved readability, and additional resources with API references for better user guidance.

Issue: N/A (documentation improvement)

Dependencies: None

Twitter handle: @colesmcintosh


Changes Made:

  • Improved description of the Salesforce Toolkit's capabilities and features
  • Added detailed setup instructions for authentication using environment variables
  • Updated code snippets to use consistent parameter naming and improved readability
  • Included additional resources and API references for better user guidance
  • Enhanced overall documentation structure and clarity

Files Modified:

  • docs/docs/integrations/tools/salesforce.ipynb (83 insertions, 36 deletions)

This is a documentation-only change that improves the user experience for developers working with the Salesforce Toolkit. The changes are backwards compatible and follow LangChain's documentation standards.

Updated the Salesforce integration notebook to provide a more comprehensive overview of the `langchain-salesforce` package. Key changes include:

- Improved description of the tool's capabilities and features.
- Added detailed setup instructions for authentication using environment variables.
- Updated code snippets to use consistent parameter naming and improved readability.
- Included additional resources and API references for better user guidance.
Copy link

vercel bot commented May 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2025 2:27pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels May 28, 2025
Enhanced the Salesforce integration notebook by improving code readability and consistency. Key changes include:

- Added a unique ID to the markdown cell for better tracking.
- Streamlined the initialization of the Salesforce tool by consolidating parameters into a single line.
- Corrected formatting in the query definition and data handling for clarity.
- Removed unnecessary blank lines to improve overall presentation.
Copy link
Collaborator

@eyurtsev eyurtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nits, but looks good otherwise

"\n",
"## Overview\n",
"\n",
"This notebook provides examples of interacting with Salesforce using LangChain.\n"
"The `langchain-salesforce` package provides a powerful integration between LangChain and Salesforce CRM,\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The target audience is technical, so using language which is more technical and less sales/marketing oriented is more appropriate. The general guideline is to drop adjectives like "powerful".

"\n",
"## Getting Your Security Token\n",
"If you need a security token:\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it back in - accidental removal when trying to re-write

"\n",
"- [Salesforce SOQL Reference](https://developer.salesforce.com/docs/atlas.en-us.soql_sosl.meta/soql_sosl/)\n",
"- [Salesforce REST API Developer Guide](https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/)\n",
"- [LangChain Tools Documentation](https://python.langchain.com/docs/modules/tools/)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to remove the internal cross-reference to tools. Focusing on the things that are salesforce specific or integration specific is good for the additional resources.

@eyurtsev eyurtsev self-assigned this May 29, 2025
Copy link

codspeed-hq bot commented May 29, 2025

CodSpeed Walltime Performance Report

Merging #31387 will not alter performance

Comparing colesmcintosh:master (ab3bef4) with master (17f34ba)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

Copy link

codspeed-hq bot commented May 29, 2025

CodSpeed Instrumentation Performance Report

Merging #31387 will not alter performance

Comparing colesmcintosh:master (ab3bef4) with master (17f34ba)

Summary

✅ 13 untouched benchmarks

Refined the Salesforce integration notebook by simplifying descriptions and improving formatting. Key changes include:

- Shortened the overview of the `langchain-salesforce` package.
- Enhanced clarity in the key features section.
- Less marketing/sales wording
- Improved setup instructions and added details for obtaining a security token.
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 2, 2025
@eyurtsev eyurtsev merged commit ffa32a1 into langchain-ai:master Jun 2, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants