Skip to content

fix:RunnablePick may not return a dict if keys is a string #31309 #31321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix:RunnablePick may not return a dict if keys is a string #31309 #31321

wants to merge 1 commit into from

Conversation

Swastik-Swarup-Dash
Copy link
Contributor

@Swastik-Swarup-Dash Swastik-Swarup-Dash commented May 22, 2025 •
edited
Loading

Change made From:

class RunnablePick(RunnableSerializable[dict[str, Any], dict[str, Any]]):

To:

class RunnablePick(RunnableSerializable[dict[str, Any], Any]):

As suggested by @cbornet

@vercel Vercel
Copy link

vercel bot commented May 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview May 22, 2025 4:22pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels May 22, 2025
ccurme
ccurme reviewed May 23, 2025
View reviewed changes
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unit test to demonstrate the change? The test should fail prior to the change and pass after.

@ccurme ccurme added the needs test PR needs to be updated with tests label May 23, 2025
@cbornet
Copy link
Collaborator

cbornet commented May 24, 2025

I think we should first discuss in #31309 what should be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccurme ccurme ccurme left review comments

Assignees
No one assigned
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature needs test PR needs to be updated with tests size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Swastik-Swarup-Dash @cbornet @ccurme