-
Notifications
You must be signed in to change notification settings - Fork 17k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused Context API #30382
base: master
Are you sure you want to change the base?
Remove unused Context API #30382
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
I'm in favor, but are we sure no one is using it? |
|
||
|
||
@beta() | ||
class ContextGet(RunnableSerializable): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of abundance of caution maybe we leave stub class with nice deprecation message on init?
imo pretty safe to remove. esp because its beta. but i still would like a stub class + warning |
OK let's remove and add a stub for a warning so it's clear that the code is gone |
Never documented and makes it easier to create memory leaks