Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Context API #30382

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove unused Context API #30382

wants to merge 2 commits into from

Conversation

hinthornw
Copy link
Collaborator

@hinthornw hinthornw commented Mar 19, 2025

Never documented and makes it easier to create memory leaks

Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 31, 2025 2:48pm

@hinthornw hinthornw marked this pull request as ready for review March 19, 2025 20:30
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Mar 19, 2025
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 19, 2025
@eyurtsev
Copy link
Collaborator

I'm in favor, but are we sure no one is using it?



@beta()
class ContextGet(RunnableSerializable):
Copy link
Collaborator

@baskaryan baskaryan Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of abundance of caution maybe we leave stub class with nice deprecation message on init?

@baskaryan
Copy link
Collaborator

I'm in favor, but are we sure no one is using it?

imo pretty safe to remove. esp because its beta. but i still would like a stub class + warning

@eyurtsev
Copy link
Collaborator

OK let's remove and add a stub for a warning so it's clear that the code is gone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants