-
Notifications
You must be signed in to change notification settings - Fork 17k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community: Add sqldocstore support for ParentChildRetriever #30300
base: master
Are you sure you want to change the base?
Conversation
Add aprep outputs to chain base
add private repo build
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Co-authored-by: Oskar Stark <[email protected]>
I propose to rename the PR title to:
|
Found two potential issues. Metadata Loss: The Inconsistent Type Hint: The type hint for |
@a-holm thanks for the comments! I'll address them ASAP. |
Description
This PR aims to add support for
sqldocstore
to be used byParentDocumentRetriever
classParentDocumentRetriever
class is passing in Documents tomset
here:https://github.com/langchain-ai/langchain/blob/master/libs/langchain/langchain/retrievers/parent_document_retriever.py#L135
Issue
Using
langchain_community.storage.sql.SQLStore
with theParentChildRetriever
causes the following exception:Add tests and docs
A new test has been added to make sure that
SqlDocstore
supports langchain document types.