Skip to content

community: update RankLLM integration and fix LangChain deprecation#29931

Merged
ccurme (ccurme) merged 14 commits intolangchain-ai:masterfrom
b8zhong:rankllm-update
Mar 31, 2025
Merged

community: update RankLLM integration and fix LangChain deprecation#29931
ccurme (ccurme) merged 14 commits intolangchain-ai:masterfrom
b8zhong:rankllm-update

Conversation

@b8zhong
Copy link
Copy Markdown
Contributor

@b8zhong Brayden Zhong (b8zhong) commented Feb 23, 2025

Community: update RankLLM integration and fix LangChain deprecation

  • Description:

  • Dependencies: No new dependencies added.

  • Tests and Docs:

    • Updated RankLLM documentation (docs/docs/integrations/document_transformers/rankllm-reranker.ipynb).
    • Fixed LangChain usage in related code examples.
  • Lint and Test:

    • Ran make format, make lint, and verified functionality after updates.
    • No breaking changes introduced.
Additional guidelines:
- Make sure optional dependencies are imported within a function.
- Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
- Most PRs should not touch more than one package.
- Changes should be backwards compatible.
- If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 1:46pm

@dosubot dosubot Bot added size:L labels Feb 23, 2025
@b8zhong
Copy link
Copy Markdown
Contributor Author

ccurme (@ccurme) Hey! Thanks for reviewing my last PR! Wondering if you have any advice here? Weird that lint fails in 3.9 and 3.12...
Locally -- this is what I get:

uv run -p 3.9 --group lint ruff check docs/docs/integrations/document_transformers/rankllm-reranker.ipynb
Using CPython 3.9.21
Removed virtual environment at: .venv
Creating virtual environment at: .venv
Installed 84 packages in 63ms
All checks passed!
uv run -p 3.12 --group lint ruff check docs/docs/integrations/document_transformers/rankllm-reranker.ipynb
Using CPython 3.12.9
Removed virtual environment at: .venv
Creating virtual environment at: .venv
Installed 80 packages in 70ms
All checks passed!

Copy link
Copy Markdown
Collaborator

@ccurme ccurme (ccurme) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give some context for this? There are many breaking changes here. Is the current version broken with the latest rank_llm? Is maintaining backward-compatibility feasible or worth it?

There are basically no tests for this abstraction so it's difficult to know the current state.

@ccurme
Copy link
Copy Markdown
Collaborator

For the linter: if things are set up correctly you should be able to run make format to auto-format and make lint to run the checks locally (see the contributing guide).

@ccurme ccurme (ccurme) self-assigned this Feb 26, 2025
@ccurme
Copy link
Copy Markdown
Collaborator

Can you give some context for this? There are many breaking changes here. Is the current version broken with the latest rank_llm? Is maintaining backward-compatibility feasible or worth it?

There are basically no tests for this abstraction so it's difficult to know the current state.

Hi Brayden Zhong (@b8zhong), friendly ping on this.

@b8zhong
Copy link
Copy Markdown
Contributor Author

Hi ccurme (@ccurme) sorry for the massive delay. I reset the code changes... only changes are to the notebook & some doc info. Let me know if you think it's ok to merge in.. ?

I'm not sure why the linting is complaining, it's about a line on the ipynb that's not an import I think.

@b8zhong
Copy link
Copy Markdown
Contributor Author

Friendly bump; I know I was the one that forgot in the first place :)

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 27, 2025

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@b8zhong
Copy link
Copy Markdown
Contributor Author

ccurme (@ccurme) Thanks for helping out here!

@ccurme ccurme (ccurme) merged commit e4515f3 into langchain-ai:master Mar 31, 2025
13 checks passed
@dosubot dosubot Bot added the lgtm label Mar 31, 2025
@b8zhong Brayden Zhong (b8zhong) deleted the rankllm-update branch March 31, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants