community: update RankLLM integration and fix LangChain deprecation#29931
community: update RankLLM integration and fix LangChain deprecation#29931ccurme (ccurme) merged 14 commits intolangchain-ai:masterfrom b8zhong:rankllm-update
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
ccurme (@ccurme) Hey! Thanks for reviewing my last PR! Wondering if you have any advice here? Weird that lint fails in 3.9 and 3.12... uv run -p 3.9 --group lint ruff check docs/docs/integrations/document_transformers/rankllm-reranker.ipynb
Using CPython 3.9.21
Removed virtual environment at: .venv
Creating virtual environment at: .venv
Installed 84 packages in 63ms
All checks passed!uv run -p 3.12 --group lint ruff check docs/docs/integrations/document_transformers/rankllm-reranker.ipynb
Using CPython 3.12.9
Removed virtual environment at: .venv
Creating virtual environment at: .venv
Installed 80 packages in 70ms
All checks passed! |
ccurme (ccurme)
left a comment
There was a problem hiding this comment.
Can you give some context for this? There are many breaking changes here. Is the current version broken with the latest rank_llm? Is maintaining backward-compatibility feasible or worth it?
There are basically no tests for this abstraction so it's difficult to know the current state.
|
For the linter: if things are set up correctly you should be able to run |
Hi Brayden Zhong (@b8zhong), friendly ping on this. |
|
Hi ccurme (@ccurme) sorry for the massive delay. I reset the code changes... only changes are to the notebook & some doc info. Let me know if you think it's ok to merge in.. ? I'm not sure why the linting is complaining, it's about a line on the ipynb that's not an import I think. |
|
Friendly bump; I know I was the one that forgot in the first place :) |
|
Deployment failed with the following error: |
|
ccurme (@ccurme) Thanks for helping out here! |
Community: update RankLLM integration and fix LangChain deprecation
Description:
ModelTypeenum (VICUNA,ZEPHYR,GPT) to align with RankLLM's latest implementation.chain({query})tochain.invoke({query})to resolve LangChain 0.1.0 deprecation warnings from Community: RankLLMRerank AttributeError (Handle list-based rerank results) #29840.Dependencies: No new dependencies added.
Tests and Docs:
docs/docs/integrations/document_transformers/rankllm-reranker.ipynb).Lint and Test:
make format,make lint, and verified functionality after updates.