Added user agent #176
Merged
Added user agent #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleknap
reviewed
Oct 16, 2025
Comment on lines
356
to
357
| headers = mock_container_client_cls.call_args[1] | ||
| assert headers["user_agent"] == user_agent |
There was a problem hiding this comment.
Small nitpick, but let's name the variable name here client_kwargs as the value passed hear is not directly the user agent value and is more a client configuration value.
| ] == expected_custom_csv_documents_with_columns | ||
|
|
||
|
|
||
| def test_user_agent( |
There was a problem hiding this comment.
Can we add a test case for the async client as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the user agent for langchain-azure-storage.