Skip to content

Conversation

mdrxy
Copy link
Collaborator

@mdrxy mdrxy commented Sep 21, 2025

No description provided.

don't want these being unchecked to count against the "tasks completed" ux on the PRs page - I imagine editing descriptions will be cumbersome
@Copilot Copilot AI review requested due to automatic review settings September 21, 2025 06:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Normalize formatting of the final two checklist items in the PR template.

  • Align final two items with the rest of the checklist
  • Converted the last two items from task list checkboxes to plain bullets

Comment on lines +36 to +37
- I have gotten approval from the relevant reviewers
- (Internal team members only / optional) I have created a preview deployment using the [Create Preview Branch workflow](https://github.com/langchain-ai/docs/actions/workflows/create-preview-branch.yml)
Copy link
Preview

Copilot AI Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines were converted from task list items to plain bullets, breaking the interactive checkboxes in GitHub's PR UI and creating inconsistency with the preceding checklist items. Restore the task list syntax by adding [ ] so reviewers can check them off, e.g., '- [ ] I have gotten approval from the relevant reviewers' and '- [ ] (Internal team members only / optional) I have created a preview deployment using the Create Preview Branch workflow'.

Suggested change
- I have gotten approval from the relevant reviewers
- (Internal team members only / optional) I have created a preview deployment using the [Create Preview Branch workflow](https://github.com/langchain-ai/docs/actions/workflows/create-preview-branch.yml)
- [ ] I have gotten approval from the relevant reviewers
- [ ] (Internal team members only / optional) I have created a preview deployment using the [Create Preview Branch workflow](https://github.com/langchain-ai/docs/actions/workflows/create-preview-branch.yml)

Copilot uses AI. Check for mistakes.

Copy link

Preview ID generated: preview-mdrxyf-1758436175-f56bf72

@lnhsingh lnhsingh enabled auto-merge (squash) September 22, 2025 14:57
Copy link

Preview ID generated: preview-mdrxyf-1758553108-8f97d9a

@lnhsingh lnhsingh merged commit 3384ab8 into main Sep 22, 2025
12 checks passed
@lnhsingh lnhsingh deleted the mdrxy/final-two-checklist branch September 22, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants