Skip to content

Conversation

lnhsingh
Copy link
Collaborator

@lnhsingh lnhsingh commented Sep 18, 2025

Reverts #580

MERGE ON TUESDAY

@Copilot Copilot AI review requested due to automatic review settings September 18, 2025 16:05
@lnhsingh lnhsingh requested a review from katmayb as a code owner September 18, 2025 16:05
@github-actions github-actions bot added the langsmith For docs changes to LangSmith label Sep 18, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous revert and restores the composite evaluators documentation for LangSmith. It adds back the ability to combine multiple evaluator scores into a single composite score using both SDK and UI methods.

  • Restores complete documentation for composite evaluators functionality
  • Adds guidance for both programmatic (SDK) and UI-based composite evaluator creation
  • Includes comprehensive examples with weighted averaging and sum aggregation methods

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/langsmith/composite-evaluators.mdx Complete documentation file for composite evaluators with SDK examples and UI workflow
src/docs.json Navigation entry to include the composite evaluators page in the LangSmith evaluators section

Copy link

Preview ID generated: preview-revert-1758211550-bac30a7

@Copilot Copilot AI review requested due to automatic review settings September 22, 2025 14:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.

load_dotenv()

# Access environment variables
openai_api_key = os.getenv('OPENAI_API_KEY')
Copy link
Preview

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable oai_client is used throughout the code but is never initialized. You need to add oai_client = OpenAI(api_key=openai_api_key) after retrieving the API key.

Suggested change
openai_api_key = os.getenv('OPENAI_API_KEY')
openai_api_key = os.getenv('OPENAI_API_KEY')
oai_client = OpenAI(api_key=openai_api_key)

Copilot uses AI. Check for mistakes.

WEIGHTED_KEY = "weighted_summary"

# Pull experiment results
EXPERIMENT_ID = list(client.list_projects(reference_dataset_name=DATASET_NAME, limit=1))[0].id
Copy link
Preview

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable DATASET_NAME is not defined. It should reference the dataset name, likely dataset.name from the earlier dataset creation.

Copilot uses AI. Check for mistakes.

Copy link

Preview ID generated: preview-revert-1758552995-531bd21

Copy link

Preview ID generated: preview-revert-1758643688-56cd113

@Copilot Copilot AI review requested due to automatic review settings September 23, 2025 16:10
@tanushree-sharma tanushree-sharma enabled auto-merge (squash) September 23, 2025 16:10
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link

Preview ID generated: preview-revert-1758643897-127f7e6

@tanushree-sharma tanushree-sharma merged commit 98c9bad into main Sep 23, 2025
12 checks passed
@tanushree-sharma tanushree-sharma deleted the revert-580-revert-556-composite-scores branch September 23, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
langsmith For docs changes to LangSmith
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants