Ensure float operations in SoundSynthesizerEffects & CompassCalibrator.
#454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-carlos
force-pushed
the
float-math-funcs
branch
2 times, most recently
from
f0ea2e4 to
a917616
Compare
microbit-carlos
changed the title
SoundSynthesizerEffects.SoundSynthesizerEffects & CompassCalibrator.
microbit-carlos
force-pushed
the
float-math-funcs
branch
from
a917616 to
1d94b2b
Compare
microbit-carlos
force-pushed
the
float-math-funcs
branch
from
1d94b2b to
e67bb09
Compare
|
As the PR in codal-core has been merged, I've udpated target-locked.json to point to that commit and that shows the half KB of flash saving from having fewer/smaller math functions included in the build. |
Avoid implicit int promotion to doubles when the final results are stored in floats, and use float versions of math function when the results are stored in floats as well.
microbit-carlos
force-pushed
the
float-math-funcs
branch
from
e67bb09 to
d0abb3f
Compare
Build diffBase commit: 73329cea9f963fe3129f7f51c2a668dc50c952e5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR, which includes files in codal-core like
LevelDetectorSPL, and together with this PR it saves >400 bytes of flash:Edit: Also ensured float literals in a couple of other files to avoid implicit double promotion.