Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Improve save_artifact path calculation #2461

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Feb 14, 2025

Fixes

Signed-off-by: Lukas Heumos <[email protected]>
Signed-off-by: Lukas Heumos <[email protected]>
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.53%. Comparing base (d503387) to head (627a4d8).
Report is 57 commits behind head on main.

Files with missing lines Patch % Lines
lamindb/curators/__init__.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2461      +/-   ##
==========================================
- Coverage   91.71%   91.53%   -0.19%     
==========================================
  Files          62       64       +2     
  Lines        9138     9895     +757     
==========================================
+ Hits         8381     9057     +676     
- Misses        757      838      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 14, 2025

@github-actions github-actions bot temporarily deployed to pull request February 14, 2025 11:24 Inactive
Signed-off-by: Lukas Heumos <[email protected]>
@Zethson Zethson changed the title 🎨 Fix write path 🐛 Improve save_artifact path calculation Feb 14, 2025
Signed-off-by: Lukas Heumos <[email protected]>
Signed-off-by: Lukas Heumos <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request February 14, 2025 12:30 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant