Make initial summary print aliases with namespace #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichiardi
force-pushed
the
fix-print-namespaced-aliass
branch
2 times, most recently
from
8b79258 to
7413180
Compare
They were printed without the namespace but the namespace can be used to indicate where the alias comes from and it is important to see in the summary. This patch fixes that by changing `name` to `str`. Before: ``` Aliases: dev, cider, zprint, local ``` After: ``` Aliases: :dev, :home/cider, :home/zprint, :mine/local ```
arichiardi
force-pushed
the
fix-print-namespaced-aliass
branch
from
7413180 to
e2dc1c3
Compare
|
LGTM! this will definitely be helpful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were printed without the namespace but the namespace can be used to indicate where the alias comes from and it is important to see in the summary. This patch fixes that by changing
nametostr.Before:
After: