Skip to content

Make initial summary print aliases with namespace #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

arichiardi
Copy link
Contributor

@arichiardi arichiardi commented Apr 16, 2025

They were printed without the namespace but the namespace can be used to indicate where the alias comes from and it is important to see in the summary. This patch fixes that by changing name to str.

Before:

Aliases: dev, cider, zprint, local

After:

Aliases: :dev, :home/cider, :home/zprint, :mine/local

@arichiardi arichiardi force-pushed the fix-print-namespaced-aliass branch 2 times, most recently from 8b79258 to 7413180 Compare April 16, 2025 09:52
They were printed without the namespace but the namespace can be used to
indicate where the alias comes from and it is important to see in the
summary. This patch fixes that by changing `name` to `str`.

Before:
```
Aliases: dev, cider, zprint, local
```
After:
```
Aliases: :dev, :home/cider, :home/zprint, :mine/local
```
@arichiardi arichiardi force-pushed the fix-print-namespaced-aliass branch from 7413180 to e2dc1c3 Compare May 27, 2025 13:14
@oxalorg
Copy link
Member

oxalorg commented May 30, 2025

LGTM! this will definitely be helpful

@oxalorg oxalorg merged commit a614b7d into lambdaisland:main May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants