fix: std requires alloc #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rust standard library already requires a global allocator. This means all features that only depend on that should be usable when
stdis enabled, so let's make that implication explicit in our manifest.Pull Request type
What is the current behavior?
You need to explicitly enable
alloceven if you're building withstd.What is the new behavior?
Enabling
stdalways enablesalloc.Does this introduce a breaking change?
Technically, yes. You can no longer trigger a build with
stdbut no global allocator. In practice, no, those builds were already broken.