Replay: Squash with v0.14.0-rc.3

.cargo/config.toml

@@ -1,5 +1,4 @@
 [env]
-CAIRO_NATIVE_RUNTIME_LIBRARY = "../blockifier/libcairo_native_runtime.a"
 LLVM_SYS_191_PREFIX = "/usr/lib/llvm-19/"
 MLIR_SYS_190_PREFIX = "/usr/lib/llvm-19/"
 TABLEGEN_190_PREFIX = "/usr/lib/llvm-19/"

.github/actions/bootstrap/action.yml

@@ -9,10 +9,6 @@ inputs:
 runs:
   using: "composite"
   steps:
-    # required to clone native as a gitsubmodule
-    - name: Submodules update.
-      run: git submodule update --init --recursive
-      shell: bash
     - name: Install rust.
       uses: ./.github/actions/install_rust
       with:

.github/actions/install_rust/action.yml

@@ -13,7 +13,7 @@ runs:
       with:
         cache-base: main(-v[0-9].*)?
         inherit-toolchain: true
-        bins: [email protected].0, cargo-machete
+        bins: [email protected].3, cargo-machete
         # Install additional non-default toolchains (for rustfmt for example), NOP if input omitted.
         channel: ${{ inputs.extra_rust_toolchains }}
       env:

.github/workflows/blockifier_ci.yml

@@ -49,7 +49,7 @@ concurrency:
 
 jobs:
   feature-combo-builds:
-    runs-on: starkware-ubuntu-latest-medium
+    runs-on: starkware-ubuntu-24.04-medium
     steps:
       - uses: actions/checkout@v4
         with:

.github/workflows/blockifier_compiled_cairo.yml

@@ -29,7 +29,7 @@ concurrency:
 
 jobs:
   verify_cairo_file_dependencies:
-    runs-on: starkware-ubuntu-20-04-medium
+    runs-on: starkware-ubuntu-24.04-medium
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/bootstrap

.github/workflows/blockifier_post-merge.yml

@@ -13,7 +13,7 @@ on:
 jobs:
   if_merged:
     if: github.event.pull_request.merged == true
-    runs-on: starkware-ubuntu-20-04-medium
+    runs-on: starkware-ubuntu-24.04-medium
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/bootstrap

.github/workflows/blockifier_reexecution_ci.yml

@@ -33,7 +33,7 @@ concurrency:
 
 jobs:
   blockifier_reexecution:
-    runs-on: starkware-ubuntu-latest-medium
+    runs-on: starkware-ubuntu-24.04-medium
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/bootstrap

.github/workflows/clean_stale_prs.yml

@@ -9,7 +9,7 @@ on:
 jobs:
   stale:
     name: 🧹 Clean up stale issues and PRs
-    runs-on: starkware-ubuntu-latest-small
+    runs-on: starkware-ubuntu-24.04-small
     steps:
       - name: 🚀 Run stale
         uses: actions/stale@v3

.github/workflows/committer_ci.yml

@@ -32,7 +32,7 @@ concurrency:
 
 jobs:
   run-regression-tests:
-    runs-on: starkware-ubuntu-latest-medium
+    runs-on: starkware-ubuntu-24.04-medium
     if: ${{ github.event_name == 'pull_request' }}
     steps:
       - uses: actions/checkout@v4
@@ -48,7 +48,7 @@ jobs:
       - run: cargo test -p committer_cli --release -- --include-ignored test_regression
 
   benchmarking:
-    runs-on: starkware-ubuntu-latest-medium
+    runs-on: starkware-ubuntu-24.04-medium
     if: ${{ github.event_name == 'pull_request' }}
     steps:
       # Checkout the base branch to get the old code.

.github/workflows/committer_cli_push.yml

@@ -15,6 +15,7 @@ on:
       - 'crates/starknet_api/**'
       - 'crates/starknet_committer/**'
       - 'crates/starknet_patricia/**'
+      - 'rust-toolchain.toml'
       - 'scripts/dependencies.sh'
 
   pull_request:
@@ -32,6 +33,7 @@ on:
       - 'crates/starknet_api/**'
       - 'crates/starknet_committer/**'
       - 'crates/starknet_patricia/**'
+      - 'rust-toolchain.toml'
       - 'scripts/dependencies.sh'
 
 env:
@@ -48,7 +50,7 @@ concurrency:
 
 jobs:
   gcs-push:
-    runs-on: starkware-ubuntu-20-04-medium
+    runs-on: starkware-ubuntu-24.04-medium
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/bootstrap
@@ -68,7 +70,7 @@ jobs:
         run: echo "SHORT_HASH=${COMMIT_SHA:0:7}" >> $GITHUB_ENV
 
       - name: Build CLI binary
-        run: ./build_native_in_docker.sh cargo build -p committer_cli -r --bin committer_cli --target-dir CLI_TARGET
+        run: ./build_native_in_docker.sh rustup toolchain install && cargo build -p committer_cli -r --bin committer_cli --target-dir CLI_TARGET
 
       - id: auth
         uses: "google-github-actions/auth@v2"

.github/workflows/deployment.yml

@@ -21,7 +21,7 @@ on:
 
 jobs:
   deployment:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
 

.github/workflows/lock_closed_prs.yml

@@ -9,7 +9,7 @@ on:
 jobs:
   lock:
     name: 🔒 Lock closed issues and PRs
-    runs-on: starkware-ubuntu-latest-small
+    runs-on: starkware-ubuntu-24.04-small
     steps:
       - uses: dessant/[email protected]
         with:

.github/workflows/main.yml

@@ -33,7 +33,7 @@ concurrency:
 
 jobs:
   code_style:
-    runs-on: starkware-ubuntu-20-04-medium
+    runs-on: starkware-ubuntu-24.04-medium
     steps:
       # Environment setup.
       - uses: actions/checkout@v4
@@ -96,14 +96,14 @@ jobs:
         run: cargo machete
 
   run-workspace-tests:
-    runs-on: starkware-ubuntu-latest-medium
+    runs-on: starkware-ubuntu-24.04-medium
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/bootstrap
       - run: cargo test -p workspace_tests
 
   run-tests:
-    runs-on: starkware-ubuntu-latest-large
+    runs-on: starkware-ubuntu-24.04-large
     steps:
       - uses: actions/checkout@v4
         with:

.github/workflows/main_nightly.yml

@@ -9,7 +9,7 @@ env:
 
 jobs:
   codecov:
-    runs-on: starkware-ubuntu-latest-large
+    runs-on: starkware-ubuntu-24.04-large
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/bootstrap

.github/workflows/main_pr.yml

@@ -23,7 +23,7 @@ concurrency:
 
 jobs:
   commitlint:
-    runs-on: starkware-ubuntu-latest-small
+    runs-on: starkware-ubuntu-24.04-small
     steps:
       - uses: actions/checkout@v4
         with:
@@ -46,7 +46,7 @@ jobs:
         run: echo "$TITLE" | commitlint --verbose
 
   merge-gatekeeper:
-    runs-on: starkware-ubuntu-latest-small
+    runs-on: starkware-ubuntu-24.04-small
     # Restrict permissions of the GITHUB_TOKEN.
     # Docs: https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
     permissions:

.github/workflows/merge_paths_ci.yml

@@ -27,7 +27,7 @@ concurrency:
 
 jobs:
   merge-paths-test:
-    runs-on: starkware-ubuntu-latest-small
+    runs-on: starkware-ubuntu-24.04-small
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-python@v5

.github/workflows/papyrus/helm-install.yml

@@ -14,7 +14,7 @@ on:
 
 jobs:
   deploy-teardown:
-    runs-on: starkware-ubuntu-latest-small
+    runs-on: starkware-ubuntu-24.04-small
     permissions:
       contents: "read"
       id-token: "write"

.github/workflows/papyrus_benchmark.yaml

@@ -8,7 +8,7 @@ on:
 
 jobs:
   storage-benchmark:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     permissions:
       contents: "write"
       id-token: "write"

.github/workflows/papyrus_ci.yml

@@ -36,7 +36,7 @@ concurrency:
 
 jobs:
   executable-run:
-    runs-on: starkware-ubuntu-latest-medium
+    runs-on: starkware-ubuntu-24.04-medium
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/bootstrap
@@ -51,7 +51,7 @@ jobs:
           & sleep 30 ; kill $!
 
   executable-run-no-rpc:
-    runs-on: starkware-ubuntu-latest-medium
+    runs-on: starkware-ubuntu-24.04-medium
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/bootstrap
@@ -68,7 +68,7 @@ jobs:
   # FIXME: Job is currently running out of disk space, error is hidden inside the `Annoatations`
   # tab on github. FIX THE ISSUE AND RE-ENABLE THE JOB.
   # p2p-sync-e2e-test:
-  #   runs-on: ubuntu-latest
+  #   runs-on: starkware-ubuntu-24.04-medium
   #   steps:
   #     - uses: actions/checkout@v4
   #     - uses: ./.github/actions/bootstrap
@@ -80,7 +80,7 @@ jobs:
   #       run: scripts/papyrus/p2p_sync_e2e_test/main.sh ${{ secrets.CI_BASE_LAYER_NODE_URL }}
 
   integration-test:
-    runs-on: starkware-ubuntu-latest-medium
+    runs-on: starkware-ubuntu-24.04-medium
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/bootstrap
@@ -93,7 +93,7 @@ jobs:
           cargo run -r -p papyrus_node --bin central_source_integration_test --features="futures-util tokio-stream"
 
   test-no-rpc:
-    runs-on: starkware-ubuntu-latest-medium
+    runs-on: starkware-ubuntu-24.04-medium
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/bootstrap
@@ -102,9 +102,8 @@ jobs:
         env:
           SEED: 0
 
-
   build-papyrus-utilities-image:
-    runs-on: starkware-ubuntu-latest-medium
+    runs-on: starkware-ubuntu-24.04-medium
     steps:
       - uses: actions/checkout@v4
       - name: Set up Docker Buildx
@@ -120,7 +119,7 @@ jobs:
           cache-to: type=gha,mode=max,scope=buildkit-ci
 
   random-table-test:
-    runs-on: starkware-ubuntu-latest-medium
+    runs-on: starkware-ubuntu-24.04-medium
     steps:
       - uses: actions/checkout@v4
       # run this job only if the path 'crates/papyrus_storage/src/db/**' is changed, because it takes around 2 minutes.

.github/workflows/papyrus_docker-publish.yml

@@ -40,7 +40,7 @@ env:
 
 jobs:
   docker-build-push:
-    runs-on: starkware-ubuntu-latest-large
+    runs-on: starkware-ubuntu-24.04-large
 
     steps:
       - name: Checkout repository
@@ -77,6 +77,9 @@ jobs:
             type=ref,event=pr
             # set `main*` tag for the default / release branches.
             type=raw,value={{branch}},enable=${{ github.event_name == 'push' && contains(github.ref, 'main') }}
+            # set `{branch}-{tag}` tag for tag push events.
+            type=raw,value={{tag}},enable=${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags') }}
+            # For manual triggers of the workflow:
             type=raw,value={{branch}}{{tag}}-{{sha}},enable=${{ github.event_name == 'workflow_dispatch' }}
 
       # Build and push Docker image with Buildx
@@ -89,5 +92,4 @@ jobs:
           push: ${{ github.event_name != 'pull_request' }}
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
-          cache-from: type=gha
-          cache-to: type=gha,mode=max
+          no-cache: true

.github/workflows/papyrus_nightly-tests.yml

@@ -13,7 +13,7 @@ jobs:
   GW-integration-test-ubuntu:
     uses: ./.github/workflows/papyrus_nightly-tests-call.yml
     with:
-      os: starkware-ubuntu-latest-medium
+      os: starkware-ubuntu-24.04-medium
     secrets:
       INTEGRATION_TESTNET_NODE_URL: ${{ secrets.INTEGRATION_TESTNET_NODE_URL }}
       INTEGRATION_TESTNET_SENDER_PRIVATE_KEY: ${{ secrets.INTEGRATION_TESTNET_SENDER_PRIVATE_KEY }}
@@ -88,7 +88,7 @@ jobs:
   # TODO(dvir): make this run only if the path 'crates/papyrus_storage/src/db/**' (same path as in the CI)  was changed on the
   # last day and increase the number of repetitions.
   random-table-test:
-    runs-on: starkware-ubuntu-latest-medium
+    runs-on: starkware-ubuntu-24.04-medium
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/bootstrap

.github/workflows/upload_artifacts_workflow.yml

@@ -25,6 +25,8 @@ on:
       - 'Cargo.toml'
       - 'crates/blockifier/**'
       - 'crates/native_blockifier/**'
+      - 'crates/starknet_sierra_multicompile/**'
+      - 'rust-toolchain.toml'
       - 'scripts/build_native_blockifier.sh'
       - 'scripts/dependencies.sh'
       - 'scripts/install_build_tools.sh'
@@ -44,7 +46,7 @@ env:
 
 jobs:
   native-blockifier-artifacts-push:
-    runs-on: starkware-ubuntu-latest-medium
+    runs-on: starkware-ubuntu-24.04-medium
     steps:
       - uses: actions/checkout@v4
 
@@ -132,10 +134,3 @@ jobs:
         with:
           path: "target/release/shared_executables/starknet-native-compile"
           destination: "native_blockifier_artifacts/${{ env.SHORT_HASH }}/release/"
-
-      - name: Upload libcairo_native_runtime.a to GCP
-        id: upload_lnr_file
-        uses: "google-github-actions/upload-cloud-storage@v2"
-        with:
-          path: "crates/blockifier/cairo_native/target/release/libcairo_native_runtime.a"
-          destination: "native_blockifier_artifacts/${{ env.SHORT_HASH }}/release/"

.github/workflows/verify-deps.yml

@@ -10,7 +10,7 @@ env:
 jobs:
   latest_deps:
     name: Latest Dependencies
-    runs-on: starkware-ubuntu-latest-medium
+    runs-on: starkware-ubuntu-24.04-medium
     continue-on-error: true
     steps:
       - uses: actions/checkout@v4

.gitignore

@@ -40,6 +40,3 @@ scripts/papyrus/p2p_sync_e2e_test/data_server/
 # Papyrus helm chart
 deployments/papyrus/helm/config/*
 !deployments/papyrus/helm/config/example.json
-
-# Generated file used for running contracts compiled with Cairo Native
-crates/blockifier/libcairo_native_runtime.a

BUILD

@@ -2,7 +2,6 @@
 exports_files([
     "target/release/libnative_blockifier.so",
     "target/release/shared_executables/starknet-native-compile",
-    "crates/blockifier/cairo_native/target/release/libcairo_native_runtime.a",
     "target/debug/committer_cli",
     "target/release/committer_cli",
     "target/x86_64-unknown-linux-musl/debug/committer_cli",