feat: create account from Package #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
fkrause98
reviewed
Sep 15, 2025
| /// Optional list of files specifying additional component template files to add to the | ||
| /// account. | ||
| /// List of files specifying component template files for the account. At | ||
| /// lease one component template is required. |
There was a problem hiding this comment.
Suggested change
| /// lease one component template is required. | |
| /// least one component template is required. |
There was a problem hiding this comment.
Thanks! Changed here: b285982
fkrause98
reviewed
Sep 15, 2025
Comment on lines
248
to
257
| // If a user passes in a file with the `.masp` file extension, then we | ||
| // leave the passed in path as is; since it probably is a full path. | ||
| // This is the case with cargo-miden, which displays the full path to | ||
| // stdout after compilation finishes. | ||
| let path = if path.extension().is_none() { | ||
| let path = path.with_extension(MIDEN_PACKAGE_EXTENSION); | ||
| packages_dir.join(&path) | ||
| } else { | ||
| path.clone() | ||
| }; |
There was a problem hiding this comment.
But we're not checking that this file's extension is actually .masp, right? Only that it exists.
There was a problem hiding this comment.
Great point! I'll add a check.
There was a problem hiding this comment.
Check added here: eb6884a
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
lima-limon-inc
commented
Sep 16, 2025
Comment on lines
156
to
160
| /// Optional list of files specifying additional component template files to add to the | ||
| /// account. | ||
| /// List of files specifying component template files for the account. At | ||
| /// least one component template is required. |
There was a problem hiding this comment.
Sidenote: I believe this list is not optional since at least one element has to be passed in, source: https://github.com/lambdaclass/miden-client/pull/25/files#diff-95eb60497fe9b9ad958ac1c26595181b35ee51f5e192ebe32ac9689cecb768c2L254-R360.AFAIK, this is only optional when building a wallet.
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
lima-limon-inc
force-pushed
the
fabrizioorsi-account-from-package
branch
2 times, most recently
from
27b99dd to
90c41b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds makes it so that the CLI can now extract a component template from a passed in package, via the
-p, --packagesflags.Additionally, this TODO comment was addressed, now the I/O error display more context.
Here are snippets showcasing the new error messages: