Skip to content

fix: correct benchmark data generation in Mersenne31 field benchmarks #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct benchmark data generation in Mersenne31 field benchmarks #1027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions crates/math/benches/fields/mersenne31.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,25 @@ pub type F = FieldElement<Mersenne31Field>;
pub type Fp2E = FieldElement<Degree2ExtensionField>;
pub type Fp4E = FieldElement<Degree4ExtensionField>;

/// Generates random Mersenne31 field elements for benchmarking.
/// This function creates pairs of random field elements using the same pattern
/// as other benchmark functions in the codebase.
#[inline(never)]
#[export_name = "util::rand_mersenne31_field_elements"]
pub fn rand_field_elements(num: usize) -> Vec<(F, F)> {
let mut result = Vec::with_capacity(num);
for _ in 0..result.capacity() {
for _ in 0..num {
result.push((F::new(random()), F::new(random())));
}
result
}

//TODO: Check if this is the correct way to bench.
/// Generates random Fp4E field elements for benchmarking.
/// This function creates pairs of random Fp4E elements using the same pattern
/// as other benchmark functions in the codebase.
pub fn rand_fp4e(num: usize) -> Vec<(Fp4E, Fp4E)> {
let mut result = Vec::with_capacity(num);
for _ in 0..result.capacity() {
for _ in 0..num {
result.push((
Fp4E::new([
Fp2E::new([F::new(random()), F::new(random())]),
Expand Down