-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add Index
to enable node reuse
#6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
damiramirez
wants to merge
30
commits into
main
Choose a base branch
from
feat/update-mpt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oppen
reviewed
Aug 22, 2025
Oppen
reviewed
Aug 25, 2025
Oppen
reviewed
Aug 25, 2025
Lines of code reportTotal lines added: Detailed view
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an Index that allows storing only new or modified nodes while referencing unchanged nodes by their file offsets.
To use this, we first insert nodes into our
InMemoryTrieDB
. Once we finish inserting, we can commit the root node to the DB. After that, we can commit the trie to transform the saved nodes intoNodeRef::Hash
. In the next iteration, when inserting nodes, new nodes will beNodeRef::Node
, while unchanged nodes will beNodeRef::Hash
. We use these two types to determine whether we need to serialize a node or simply reference an existing one in the DB.New
Index
Module (src/index.rs
)Refactor in
serialization.rs
NodeRef::Hash
, use the index to refer to the existing node offset.NodeRef::Node
, serialize it and save it in the DB.New format in db (file):
Update
db_benchmark.rs
. (Currently, I removed the old code and added new logic, but maybe we can keep both.)Run
make bench
Closes Deduplicated multiversion support #8