feat(l1): adjust byte code batch size (snap sync parameter)#2338
Merged
feat(l1): adjust byte code batch size (snap sync parameter)#2338
Conversation
Lines of code reportTotal lines added: Detailed view |
mpaulucci
approved these changes
Mar 28, 2025
ElFantasma
approved these changes
Mar 31, 2025
…to adjust-bytecode-batch-size
jrchatruc
pushed a commit
that referenced
this pull request
Apr 3, 2025
**Motivation** Previous changes have sped up other components of the snap sync process, making faults in the byte code fetcher more evident. The byte code fetcher used the same batch size as storage requests, 300, which is far more than the byte codes normally returned by a peer request, causing the byte code fetcher to keep on fetching the last batches when all other fetchers have already finished. This PR reduces the batch size down to 70 so that it coincides with the amount of byte codes regularly returned by peers <!-- Why does this pull request exist? What are its goals? --> **Description** * Rename constant `BATCH_SIZE` -> `STORAGE_BATCH_SIZE` * Add constant `BYTECODE_BATCH_SIZE` <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #issue_number
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
…ass#2338) **Motivation** Previous changes have sped up other components of the snap sync process, making faults in the byte code fetcher more evident. The byte code fetcher used the same batch size as storage requests, 300, which is far more than the byte codes normally returned by a peer request, causing the byte code fetcher to keep on fetching the last batches when all other fetchers have already finished. This PR reduces the batch size down to 70 so that it coincides with the amount of byte codes regularly returned by peers <!-- Why does this pull request exist? What are its goals? --> **Description** * Rename constant `BATCH_SIZE` -> `STORAGE_BATCH_SIZE` * Add constant `BYTECODE_BATCH_SIZE` <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 --> Closes #issue_number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Previous changes have sped up other components of the snap sync process, making faults in the byte code fetcher more evident. The byte code fetcher used the same batch size as storage requests, 300, which is far more than the byte codes normally returned by a peer request, causing the byte code fetcher to keep on fetching the last batches when all other fetchers have already finished.
This PR reduces the batch size down to 70 so that it coincides with the amount of byte codes regularly returned by peers
Description
BATCH_SIZE->STORAGE_BATCH_SIZEBYTECODE_BATCH_SIZECloses #issue_number