test: add signature validation runner - #36
Merged
Conversation
MegaRedHand
marked this pull request as ready for review
January 19, 2026 14:46
3 tasks
MegaRedHand
added a commit
that referenced
this pull request
Jun 10, 2026
…cs PR #36 (#430) ## 🗒️ Description / Motivation Implements the new cross-client counter `lean_aggregator_skipped_total{reason=...}` proposed in [leanMetrics PR #36](leanEthereum/leanMetrics#36), so operators can attribute missed aggregations directly instead of deriving them from coverage gauges or logs. ## What Changed | reason | When it fires in ethlambda | |---|---| | `not_aggregator` | Every interval-2 tick where the aggregator flag is off — separates "no duty" from genuine misses | | `other` | Aggregation jobs the worker never reached because the 750 ms session deadline (or actor shutdown) cancelled it, incremented by the number of dropped jobs | | `not_synced`, `missing_state`, `spawn_failed` | Never fire — ethlambda has no sync gate on aggregation, no per-target pre-state resolution, and `spawn_blocking` cannot fail to start. Seeded at zero so fleet dashboards see the full label set | - `crates/blockchain/src/metrics.rs`: `IntCounterVec` registration, reason-list const documenting the never-firing labels, two `inc_*` helpers, init seeding - `crates/blockchain/src/lib.rs`: count the skip at the interval-2 tick when not an aggregator - `crates/blockchain/src/aggregation.rs`: track attempted vs. total jobs in `run_aggregation_worker` and count the dropped remainder on cancellation ## ✅ Verification Checklist - [x] Ran `make fmt` — clean - [x] Ran `make lint` (clippy with `-D warnings`) — clean - [x] `cargo test -p ethlambda-blockchain --lib` — 29 passed Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.