chore: remove redundant Felt252<->bytes conversions and simplify #2243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianGCalderon
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature builtin contained multiple redundant Felt252 byte round-trips (to_bytes_be followed by from_bytes_be) that provided no normalization benefit since Felt252 values in this codebase are already canonical modulo the Cairo prime, and all consumers (including starknet_crypto::verify and the Cairo PIE serializers) accept or serialize felts directly. This change removes those conversions in add_signature, add_validation_rule, get_additional_data, extend_additional_data, and simplifies air_private_input for r and w computation, reducing allocations and improving clarity without altering behavior or formats.