Skip to content

cairo1-run: honor relocate_mem and trace_enabled when relocating #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

cairo1-run: honor relocate_mem and trace_enabled when relocating #2241

wants to merge 3 commits into from

Conversation

@sashass1315
Copy link

  • Fix cairo1-run to use Cairo1RunConfig.relocate_mem and trace_enabled in runner.relocate(...) instead of unconditionally relocating both memory and trace.
  • This change brings Cairo1-run behavior in line with the Cairo 0.x runner, matches CLI expectations (trace/memory requested ⇒ relocate), and avoids unnecessary relocation work.

JulianGCalderon
JulianGCalderon reviewed Oct 24, 2025
View reviewed changes
@JulianGCalderon
Copy link
Contributor

Hi @sashass1315, thanks for the contribution! Left you a small comment. Also, format seems to be failing.

@sashass1315 @JulianGCalderon
Update CHANGELOG.md
f6f2b49 
Co-authored-by: Julian Gonzalez Calderon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulianGCalderon JulianGCalderon JulianGCalderon left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sashass1315 @JulianGCalderon