Skip to content

Compile hints without unnecessary references #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: 2.x.y
Choose a base branch
from
Draft

Compile hints without unnecessary references #2231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
accc076
simplify things
FrancoGiachetta Oct 16, 2025
27177a6
format
FrancoGiachetta Oct 16, 2025
cd709fd
refactor
FrancoGiachetta Oct 16, 2025
da57d37
Merge branch '2.x.y' into compile-hints-without-unnecessary-references
FrancoGiachetta Oct 16, 2025
2f1faec
remove unnecessary if
FrancoGiachetta Oct 16, 2025
6be90a4
Merge branch 'compile-hints-without-unnecessary-references' of github…
FrancoGiachetta Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 47 additions & 1 deletion vm/src/hint_processor/builtin_hint_processor/builtin_hint_processor_definition.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ use super::{
pack::*,
},
};
use crate::Felt252;
use crate::hint_processor::hint_processor_definition::get_ids_data;
use crate::{any_box, Felt252};
use crate::{
hint_processor::builtin_hint_processor::secp::secp_utils::{SECP256R1_ALPHA, SECP256R1_P},
utils::CAIRO_PRIME,
Expand Down Expand Up @@ -184,6 +185,51 @@ impl BuiltinHintProcessor {
}

impl HintProcessorLogic for BuiltinHintProcessor {
fn compile_hint(
&self,
hint_code: &str,
ap_tracking_data: &ApTracking,
reference_ids: &HashMap<String, usize>,
references: &[HintReference],
constants: Rc<HashMap<String, Felt252>>,
) -> Result<Box<dyn Any>, crate::vm::errors::vm_errors::VirtualMachineError> {
let ids_data = match hint_code {
hint_code::ADD_SEGMENT
| hint_code::ASSERT_LE_FELT_EXCLUDED_2
| hint_code::ASSERT_LE_FELT_EXCLUDED_1
| hint_code::ASSERT_LE_FELT_EXCLUDED_0
| hint_code::VM_EXIT_SCOPE
| hint_code::DICT_NEW
| hint_code::USORT_ENTER_SCOPE
| hint_code::USORT_VERIFY_MULTIPLICITY_ASSERT
| hint_code::SQUASH_DICT_INNER_ASSERT_LEN_KEYS
| hint_code::SQUASH_DICT_INNER_LEN_ASSERT
| hint_code::VM_ENTER_SCOPE
| hint_code::IS_ZERO_NONDET
| hint_code::IS_ZERO_INT
| hint_code::IS_ZERO_ASSIGN_SCOPE_VARS
| hint_code::IS_ZERO_ASSIGN_SCOPE_VARS_EXTERNAL_SECP
| hint_code::IS_ZERO_ASSIGN_SCOPE_VARS_ED25519
| hint_code::DIV_MOD_N_SAFE_DIV
| hint_code::DIV_MOD_N_SAFE_DIV_PLUS_ONE
| hint_code::IMPORT_SECP256R1_P
| hint_code::EC_DOUBLE_ASSIGN_NEW_Y
| hint_code::FAST_EC_ADD_ASSIGN_NEW_Y
| hint_code::XS_SAFE_DIV
| hint_code::IMPORT_SECP256R1_ALPHA
| hint_code::IMPORT_SECP256R1_N
| hint_code::EC_RECOVER_PRODUCT_DIV_M => HashMap::new(),
_ => get_ids_data(reference_ids, references)?,
};

Ok(any_box!(HintProcessorData {
code: hint_code.to_string(),
ap_tracking: ap_tracking_data.clone(),
ids_data,
constants,
}))
}

fn execute_hint(
&mut self,
vm: &mut VirtualMachine,
Expand Down
2 changes: 1 addition & 1 deletion vm/src/hint_processor/hint_processor_definition.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ pub type HintExtension = HashMap<Relocatable, Vec<Box<dyn Any>>>;
pub trait HintProcessor: HintProcessorLogic + ResourceTracker {}
impl<T> HintProcessor for T where T: HintProcessorLogic + ResourceTracker {}

fn get_ids_data(
pub(crate) fn get_ids_data(
reference_ids: &HashMap<String, usize>,
references: &[HintReference],
) -> Result<HashMap<String, HintReference>, VirtualMachineError> {
Expand Down
Loading