Skip to content

add trace not enabled error #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: stav/move_prover_input_info_to_seperate_file
Choose a base branch
from

Conversation

Stavbe
Copy link
Collaborator

@Stavbe Stavbe commented Apr 29, 2025

No description provided.

@Stavbe Stavbe force-pushed the stav/move_prover_input_info_to_seperate_file branch 4 times, most recently from 94908e8 to a292dee Compare May 4, 2025 11:35
@Stavbe Stavbe force-pushed the stav/add_trace_not_enabled_error branch from 69c3271 to c446646 Compare May 4, 2025 11:37
@Stavbe Stavbe marked this pull request as ready for review May 4, 2025 11:40
@Stavbe Stavbe requested a review from DavidLevitGurevich May 4, 2025 11:41
@Stavbe Stavbe self-assigned this May 4, 2025
Copy link

github-actions bot commented May 4, 2025

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.124 ± 0.010 2.112 2.145 1.00
head big_factorial 2.137 ± 0.005 2.131 2.145 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.056 ± 0.008 2.039 2.062 1.00
head big_fibonacci 2.071 ± 0.027 2.056 2.148 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.786 ± 0.023 7.756 7.835 1.00
head blake2s_integration_benchmark 7.787 ± 0.041 7.716 7.855 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.199 ± 0.028 2.170 2.256 1.00 ± 0.02
head compare_arrays_200000 2.192 ± 0.030 2.168 2.262 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.434 ± 0.012 1.425 1.462 1.01 ± 0.01
head dict_integration_benchmark 1.426 ± 0.016 1.418 1.470 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.233 ± 0.005 1.225 1.241 1.01 ± 0.01
head field_arithmetic_get_square_benchmark 1.226 ± 0.012 1.215 1.258 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.868 ± 0.034 7.792 7.907 1.00
head integration_builtins 7.904 ± 0.223 7.810 8.536 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.145 ± 0.024 8.116 8.181 1.00
head keccak_integration_benchmark 8.170 ± 0.076 8.082 8.362 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.166 ± 0.019 2.147 2.200 1.00
head linear_search 2.166 ± 0.013 2.154 2.200 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.521 ± 0.002 1.517 1.524 1.01 ± 0.00
head math_cmp_and_pow_integration_benchmark 1.504 ± 0.004 1.499 1.513 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.474 ± 0.008 1.459 1.486 1.01 ± 0.01
head math_integration_benchmark 1.456 ± 0.003 1.453 1.461 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.212 ± 0.004 1.208 1.221 1.00
head memory_integration_benchmark 1.225 ± 0.013 1.217 1.262 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.596 ± 0.013 1.585 1.632 1.01 ± 0.01
head operations_with_data_structures_benchmarks 1.578 ± 0.004 1.571 1.583 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 535.2 ± 2.3 532.5 539.8 1.00 ± 0.01
head pedersen 534.7 ± 2.3 532.5 540.8 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 630.2 ± 4.4 622.2 637.5 1.00 ± 0.01
head poseidon_integration_benchmark 629.0 ± 4.1 621.3 633.1 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.874 ± 0.010 1.866 1.900 1.01 ± 0.01
head secp_integration_benchmark 1.852 ± 0.012 1.843 1.882 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 628.7 ± 3.5 625.2 636.4 1.00
head set_integration_benchmark 658.8 ± 3.6 653.5 663.5 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.320 ± 0.046 4.281 4.443 1.00 ± 0.02
head uint256_integration_benchmark 4.299 ± 0.047 4.256 4.391 1.00

Copy link

codecov bot commented May 4, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.53%. Comparing base (a292dee) to head (c446646).

Files with missing lines Patch % Lines
cairo-vm-cli/src/main.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                               Coverage Diff                                @@
##           stav/move_prover_input_info_to_seperate_file    #2080      +/-   ##
================================================================================
+ Coverage                                         96.52%   96.53%   +0.01%     
================================================================================
  Files                                               103      103              
  Lines                                             43198    43192       -6     
================================================================================
- Hits                                              41697    41696       -1     
+ Misses                                             1501     1496       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant