-
Notifications
You must be signed in to change notification settings - Fork 71
feat: basic read operation for Iceberg #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Spark 3.5.5 Test ReportCommit Information
Test Summary
Test DetailsError CountsPassed Tests Diff(empty) Failed Tests |
Spark 4.0.0 Test ReportCommit Information
Test Summary
Test DetailsError CountsPassed Tests Diff(empty) Failed Tests(truncated) |
|
Before waiting for the upstream to solve the corresponding issue, import pydantic and pin the version. Tracking: |
1f1bd02 to
12d4b58
Compare
linhr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exciting!! 🚀🚀
| pub mod view_metadata; | ||
| pub mod view_metadata_builder; | ||
| pub mod view_version; | ||
|
|
||
| pub use view_metadata::*; | ||
| pub use view_metadata_builder::*; | ||
| pub use view_version::*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the view is only used for the REST API, we can remove the spec entirely from the sail-iceberg crate.
(Just a comment for future work. No need to change anything for now.)
| catalog = load_catalog( | ||
| "test_catalog", | ||
| type="sql", | ||
| uri=f"sqlite:///{tmp_path}/pyiceberg_catalog.db", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this path work on Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the Windows environment and only had escape_sql_string_literal related issues, and so far all tests have passed!
#172
https://iceberg.apache.org/spec/