-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chumsky #377
Update chumsky #377
Conversation
Gold Data ReportNotes
Commit Information
Summary
DetailsGold Data Metrics
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some gold test cases get better error messages after the update, while the error message become worse for a few other cases. I'm not sure if it's related to the library itself. More investigation is needed.
crates/sail-spark-connect/tests/gold_data/plan/ddl_analyze_table.json
Outdated
Show resolved
Hide resolved
"failure": "invalid argument: found end of input expected '''" | ||
"failure": "invalid argument: found end of input expected something else, any, ''\\'', or '''''" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lexer error message seems to have some issue with special characters.
Spark Test ReportCommit Information
Test Summary
Test DetailsError Counts
Passed Tests Diff(empty) |
No description provided.