Skip to content

chore: remove unused simulated io latency config from UringIoEngineConfig #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
detail-app wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove unused simulated io latency config from UringIoEngineConfig #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions foyer-storage/src/io/engine/uring.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,6 @@ pub struct UringIoEngineConfig {
sqpoll_idle: u32,
iopoll: bool,
weight: f64,

#[cfg(any(test, feature = "test_utils"))]
write_io_latency: Option<std::ops::Range<std::time::Duration>>,
#[cfg(any(test, feature = "test_utils"))]
read_io_latency: Option<std::ops::Range<std::time::Duration>>,
}

impl Default for UringIoEngineConfig {
Expand All @@ -71,10 +66,6 @@ impl UringIoEngineConfig {
sqpoll_idle: 10,
iopoll: false,
weight: 1.0,
#[cfg(any(test, feature = "test_utils"))]
write_io_latency: None,
#[cfg(any(test, feature = "test_utils"))]
read_io_latency: None,
}
}

Expand Down Expand Up @@ -161,20 +152,6 @@ impl UringIoEngineConfig {
self.sqpoll_idle = idle;
self
}

/// Set the simulated additional write I/O latency for testing purposes.
#[cfg(any(test, feature = "test_utils"))]
pub fn with_write_io_latency(mut self, latency: std::ops::Range<std::time::Duration>) -> Self {
self.write_io_latency = Some(latency);
self
}

/// Set the simulated additional read I/O latency for testing purposes.
#[cfg(any(test, feature = "test_utils"))]
pub fn with_read_io_latency(mut self, latency: std::ops::Range<std::time::Duration>) -> Self {
self.read_io_latency = Some(latency);
self
}
}

impl IoEngineConfig for UringIoEngineConfig {
Expand Down
Loading