Skip to content

chore(storage): remove unused Raw::into_raw_parts/from_raw_parts - #25

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-storage-remove-unused-raw-into-raw-parts-fro-90de12
Open

detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-storage-remove-unused-raw-into-raw-parts-fro-90de12

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 15, 2026

Copy link
Copy Markdown

Remove Raw::into_raw_parts and Raw::from_raw_parts from
foyer-storage/src/io/bytes.rs. Both methods have zero callers anywhere
in the codebase (production or test).

The methods were originally introduced on the old IoBuffer type and
had callers, but those callers were dropped when the io engine
abstraction was introduced (PR foyer-rs#1063). The methods were carried forward
as a rename + relocation (IoBuffer -> Raw) but never wired up to
new consumers, leaving them as dead code. The field management they
existed to support is now handled independently by the Drop, Deref,
DerefMut, Clone, and IoB::as_raw_parts impls on Raw.

History


Dead Code PRs can be configured here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants