Repository navigation
chore: remove commented-out test_store_admission test - #24
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the dead commented-out "test_store_admission" test block from
foyer-storage/src/engine/block/engine.rs (~19 LOC). The test was
commented out with a FIXME asking to move it to store level; that
intent has since been fulfilled by
test_store_enqueue_admission_reject_updatein foyer-storage/src/store.rs. The dead block also referenced APIs that
no longer exist (
store_for_test_with_admission_picker,BiasedPicker), so it cannot be re-enabled.History
Dead Code PRs can be configured here.