Repository navigation
fix(storage): remove stray debug println from FileDeviceBuilder::build - #22
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detail bug report: View on Detail
Bug
FileDeviceBuilder::buildinfoyer-storage/src/io/device/file.rsprinted the resolved device capacity to stdout on every device construction via a strayprintln!("==========> {capacity}");. Added as an ad-hoc debug marker alongside an unrelated capacity-calculation fix, it slipped through review.FileDeviceBuilderis part of the public API (re-exported through thefoyer-storageandfoyerpreludes) andbuild()runs on everyFileDeviceconstruction, so the line leaked unconditional stdout to all library consumers — bypassing the repo'stracing-based logging (the same function callstracing::warn!a few lines later) with no log-level filter or sink routing.Fix
Deleted the
println!line. The printed value was observational only and never affected the alignedcapacityused to size the device, so removal is behavior-preserving aside from dropping the unwanted stdout. No replacement diagnostic was added — the surrounding code already routes diagnostics throughtracing, so deletion restores the codebase convention. This was the onlyprintln!in foyer-storage libraryimplcode (the remaining one lives inside a#[test]body).Testing
io::engine::tests::test_io_engine(callsFileDeviceBuilder::build) passes; under--nocaptureno==========>line reaches stdout.FileDevice: captured stdout is empty (no marker). Re-inserting theprintln!reproduced==========> <capacity>on stdout, and removing it cleared it — confirming the check is sensitive to the bug.foyer-bench --file(usesFileDeviceBuilder::build) for bothpsyncandio_uringengines no longer emits the library debug marker.cargo check,cargo fmt --check(stable + nightly configs),cargo clippyfor foyer-storage and the umbrella foyer crate (incl. serde/tracing/clap/deadlock/tokio-console feature combos), the full foyer-storage and foyer test suites, doctests, and the 8 repo examples viacargo x --fast.println!/print!/eprintln!remains infoyer-storage/src/io/device/file.rs.The repo's
license-eye header checkandcargo sort --checkgates fail on the pristine baseline too (tool/config mismatch affecting 117 files and all workspace manifests), independent of this one-line deletion; this change touches neither a manifest nor any file's license header.Automatic Fixes PRs can be configured here.