fix(deps): update module go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to v0.44.0 [security]

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp	v0.34.0 -> v0.44.0

GitHub Vulnerability Alerts

CVE-2023-45142

Summary

This handler wrapper https://github.com/open-telemetry/opentelemetry-go-contrib/blob/5f7e6ad5a49b45df45f61a1deb29d7f1158032df/instrumentation/net/http/otelhttp/handler.go#L63-L65
out of the box adds labels

• http.user_agent
• http.method

that have unbound cardinality. It leads to the server's potential memory exhaustion when many malicious requests are sent to it.

Details

HTTP header User-Agent or HTTP method for requests can be easily set by an attacker to be random and long. The library internally uses httpconv.ServerRequest that records every value for HTTP method and User-Agent.

PoC

Send many requests with long randomly generated HTTP methods or/and User agents (e.g. a million) and observe how memory consumption increases during it.

Impact

In order to be affected, the program has to configure a metrics pipeline, use otelhttp.NewHandler wrapper, and does not filter any unknown HTTP methods or User agents on the level of CDN, LB, previous middleware, etc.

Others

It is similar to already reported vulnerabilities

• GHSA-5r5m-65gx-7vrh (open-telemetry/opentelemetry-go-contrib)
• GHSA-cg3q-j54f-5p7p (prometheus/client_golang)

Workaround for affected versions

As a workaround to stop being affected otelhttp.WithFilter() can be used, but it requires manual careful configuration to not log certain requests entirely.

For convenience and safe usage of this library, it should by default mark with the label unknown non-standard HTTP methods and User agents to show that such requests were made but do not increase cardinality. In case someone wants to stay with the current behavior, library API should allow to enable it.

The other possibility is to disable HTTP metrics instrumentation by passing otelhttp.WithMeterProvider option with noop.NewMeterProvider.

Solution provided by upgrading

In PR https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277, released with package version 0.44.0, the values collected for attribute http.request.method were changed to be restricted to a set of well-known values and other high cardinality attributes were removed.

References

• https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277
• https://github.com/open-telemetry/opentelemetry-go-contrib/releases/tag/v1.19.0

---

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[renovate]

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

• any of the package files in this branch needs updating, or
• the branch becomes conflicted, or
• you click the rebase/retry checkbox if found above, or
• you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go.sum

Command failed: go get -d -t ./...
go: downloading github.com/joho/godotenv v1.5.1
go: downloading github.com/gin-gonic/gin v1.9.1
go: downloading go.opentelemetry.io/otel v1.18.0
go: downloading go.uber.org/zap v1.24.0
go: downloading golang.org/x/oauth2 v0.9.0
go: downloading go.ajitem.com/zapdriver v1.4.1
go: downloading go.opentelemetry.io/otel/trace v1.18.0
go: downloading github.com/google/go-github/v45 v45.2.0
go: downloading golang.org/x/sync v0.2.0
go: downloading cloud.google.com/go/storage v1.30.1
go: downloading cloud.google.com/go v0.110.2
go: downloading github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/trace v1.13.1
go: downloading github.com/GoogleCloudPlatform/opentelemetry-operations-go v1.8.0
go: downloading go.opencensus.io v0.24.0
go: downloading go.opentelemetry.io/otel/bridge/opencensus v0.34.0
go: downloading go.opentelemetry.io/otel/sdk v1.14.0
go: downloading google.golang.org/api v0.126.0
go: downloading cloud.google.com/go/bigquery v1.52.0
go: downloading cloud.google.com/go/firestore v1.9.0
go: downloading cloud.google.com/go/logging v1.7.0
go: downloading github.com/andybalholm/brotli v1.0.5
go: downloading go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.44.0
go: downloading github.com/bradleyjkemp/cupaloy v2.3.0+incompatible
go: downloading github.com/ajstarks/svgo v0.0.0-20211024235047-1546f124cd8b
go: downloading github.com/gin-contrib/sse v0.1.0
go: downloading github.com/mattn/go-isatty v0.0.19
go: downloading golang.org/x/net v0.11.0
go: downloading go.uber.org/atomic v1.10.0
go: downloading go.uber.org/multierr v1.8.0
go: downloading cloud.google.com/go/compute/metadata v0.2.3
go: downloading google.golang.org/appengine v1.6.7
go: downloading cloud.google.com/go/compute v1.19.3
go: downloading golang.org/x/exp v0.0.0-20230626212559-97b1e661b5df
go: downloading github.com/google/go-querystring v1.1.0
go: downloading golang.org/x/crypto v0.10.0
go: downloading cloud.google.com/go/trace v1.9.0
go: downloading github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping v0.37.1
go: downloading github.com/golang/protobuf v1.5.3
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20230530153820-e85fd2cbaebc
go: downloading google.golang.org/genproto v0.0.0-20230530153820-e85fd2cbaebc
go: downloading google.golang.org/grpc v1.55.0
go: downloading cloud.google.com/go/iam v1.1.0
go: downloading github.com/google/uuid v1.3.0
go: downloading github.com/googleapis/gax-go/v2 v2.11.0
go: downloading google.golang.org/protobuf v1.30.0
go: downloading github.com/go-logr/logr v1.2.4
go: downloading go.opentelemetry.io/otel/metric v1.18.0
go: downloading go.opentelemetry.io/otel/sdk/metric v0.34.0
go: downloading github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da
go: downloading golang.org/x/time v0.1.0
go: downloading github.com/apache/arrow/go/v12 v12.0.0
go: downloading google.golang.org/genproto/googleapis/api v0.0.0-20230530153820-e85fd2cbaebc
go: downloading github.com/felixge/httpsnoop v1.0.3
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/go-playground/validator/v10 v10.14.0
go: downloading github.com/pelletier/go-toml/v2 v2.0.8
go: downloading github.com/ugorji/go/codec v1.2.11
go: downloading gopkg.in/yaml.v3 v3.0.1
go: downloading github.com/bytedance/sonic v1.9.1
go: downloading github.com/goccy/go-json v0.10.2
go: downloading github.com/json-iterator/go v1.1.12
go: downloading golang.org/x/sys v0.9.0
go: downloading golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2
go: downloading github.com/go-logr/stdr v1.2.2
go: downloading github.com/google/s2a-go v0.1.4
go: downloading golang.org/x/tools v0.9.1
go: downloading github.com/google/flatbuffers v2.0.8+incompatible
go: downloading github.com/klauspost/compress v1.15.9
go: downloading github.com/pierrec/lz4/v4 v4.1.15
go: downloading cloud.google.com/go/longrunning v0.4.2
go: downloading github.com/gabriel-vasile/mimetype v1.4.2
go: downloading github.com/go-playground/universal-translator v0.18.1
go: downloading github.com/leodido/go-urn v1.2.4
go: downloading golang.org/x/text v0.10.0
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/modern-go/reflect2 v1.0.2
go: downloading github.com/googleapis/enterprise-certificate-proxy v0.2.3
go: downloading github.com/zeebo/xxh3 v1.0.2
go: downloading github.com/go-playground/locales v0.14.1
go: downloading github.com/chenzhuoyu/base64x v0.0.0-20221115062448-fe3a3abad311
go: downloading golang.org/x/arch v0.3.0
go: downloading github.com/google/go-cmp v0.5.9
go: downloading golang.org/x/mod v0.11.0
go: downloading github.com/klauspost/asmfmt v1.3.2
go: downloading github.com/minio/asm2plan9s v0.0.0-20200509001527-cdd76441f9d8
go: downloading github.com/minio/c2goasm v0.0.0-20190812172519-36a3d3bbc4f3
go: downloading github.com/klauspost/cpuid/v2 v2.2.4
go: downloading github.com/twitchyliquid64/golang-asm v0.15.1
go: downloading github.com/golang/snappy v0.0.4
go: downloading github.com/apache/thrift v0.16.0
go: downloading go.opentelemetry.io v0.1.0
go: downloading go.opentelemetry.io/otel/metric v1.28.0
go: downloading go.opentelemetry.io/otel v1.28.0
go: contrib.rocks/apps/api/internal/tracing imports
	go.opentelemetry.io/otel/bridge/opencensus imports
	go.opentelemetry.io/otel/bridge/opencensus/internal/ocmetric imports
	go.opentelemetry.io/otel/metric/unit: cannot find module providing package go.opentelemetry.io/otel/metric/unit
go: contrib.rocks/apps/api/internal/tracing imports
	go.opentelemetry.io/otel/bridge/opencensus imports
	go.opentelemetry.io/otel/sdk/metric imports
	go.opentelemetry.io/otel/metric/instrument: cannot find module providing package go.opentelemetry.io/otel/metric/instrument
go: contrib.rocks/apps/api/internal/tracing imports
	go.opentelemetry.io/otel/bridge/opencensus imports
	go.opentelemetry.io/otel/sdk/metric imports
	go.opentelemetry.io/otel/metric/instrument/asyncfloat64: cannot find module providing package go.opentelemetry.io/otel/metric/instrument/asyncfloat64
go: contrib.rocks/apps/api/internal/tracing imports
	go.opentelemetry.io/otel/bridge/opencensus imports
	go.opentelemetry.io/otel/sdk/metric imports
	go.opentelemetry.io/otel/metric/instrument/asyncint64: cannot find module providing package go.opentelemetry.io/otel/metric/instrument/asyncint64
go: contrib.rocks/apps/api/internal/tracing imports
	go.opentelemetry.io/otel/bridge/opencensus imports
	go.opentelemetry.io/otel/sdk/metric imports
	go.opentelemetry.io/otel/metric/instrument/syncfloat64: cannot find module providing package go.opentelemetry.io/otel/metric/instrument/syncfloat64
go: contrib.rocks/apps/api/internal/tracing imports
	go.opentelemetry.io/otel/bridge/opencensus imports
	go.opentelemetry.io/otel/sdk/metric imports
	go.opentelemetry.io/otel/metric/instrument/syncint64: cannot find module providing package go.opentelemetry.io/otel/metric/instrument/syncint64
go: warning: github.com/GoogleCloudPlatform/[email protected]: retracted by module author
go: to switch to the latest unretracted version, run:
	go get github.com/GoogleCloudPlatform/opentelemetry-operations-go@latest

[cloudflare-workers-and-pages]

Deploying contributors-img with    Cloudflare Pages

Latest commit:	f6f1282
Status:	✅  Deploy successful!
Preview URL:	https://a95c408d.contributors-img.pages.dev
Branch Preview URL:	https://renovate-go-go-opentelemetry-vka0.contributors-img.pages.dev

View logs