Skip to content

Add the option to choose alignment channel by name#222

Open
acorbat wants to merge 1 commit into
labsyspharm:masterfrom
acorbat:master
Open

Add the option to choose alignment channel by name#222
acorbat wants to merge 1 commit into
labsyspharm:masterfrom
acorbat:master

Conversation

@acorbat
Copy link
Copy Markdown

@acorbat acorbat commented Jul 23, 2024

While using fileseries I encountered two problems while working with raw files from MACSims:

  1. Not all cycles have the same number of channels
  2. Order of channels was sorted while building the metadata

This made it impossible for me to select a channel for reference just by stating the number. For the first cycle it was the first channel, but for the other cycles it was the last one.

My workaround was to allow passing a string with the channel name. Metadata will then check if align channel is a string, and then check if it's inside channel_map values or not (raise Exception). If it's an int, it will use it as key of the dictionary. If it's not, then it will raise Exception.

I took the liberty of adding this to FilePatternMetadata as well.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant