Implement nested form binding for structs and arrays #2834
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2834 +/- ##
==========================================
- Coverage 93.25% 93.18% -0.07%
==========================================
Files 39 39
Lines 4652 4753 +101
==========================================
+ Hits 4338 4429 +91
- Misses 218 225 +7
- Partials 96 99 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@aldas |
| } | ||
| case MIMEApplicationXML, MIMETextXML: | ||
| if err = xml.NewDecoder(req.Body).Decode(i); err != nil { | ||
| if ute, ok := err.(*xml.UnsupportedTypeError); ok { |
| } | ||
| } | ||
|
|
||
| for key, values := range data { |
There was a problem hiding this comment.
This function is also called for header, params and query binding - should it run for them also?
| func parseFieldPath(key string) []interface{} { | ||
| var parts []interface{} | ||
| var buf strings.Builder | ||
| for i := 0; i < len(key); i++ { |
There was a problem hiding this comment.
Could it be simpler to iterate over key and stop when .[] is encountered cut these parts out of key. part = key[previous:i] this buf parts seems little bit too much.
| for ; j < len(key) && key[j] != ']'; j++ { | ||
| buf.WriteByte(key[j]) | ||
| } | ||
| index, _ := strconv.Atoi(buf.String()) |
There was a problem hiding this comment.
what if key is 18446744073709551615 (math.MaxUint64)?
or -1?
I am sure bind will panic with negative numbers
| return setWithProperType(fv.Kind(), value, fv) | ||
| } | ||
| return setValueByParts(fv, ft.Type, parts[1:], value) | ||
| case int: |
There was a problem hiding this comment.
I think these keys should be treated not as indexes but something like grouping key and only allocate so many elements in arrays/slices as there are distinct grouping keys.
just to guard against shenanigans with huge indexes
2 participants
Summary
Addresses issue #2746 by adding support for binding nested structs, arrays, and pointer fields from form data in Echo.
This enhancement allows developers to seamlessly bind complex, deeply nested web form data (such as
team.members[0].name=Alice) directly to Go structs with nested slices, pointer fields, and multiple levels of depth.Changes
team.members[0].name).winner.players[1].role=Forwardandloser.leaders[0].name=Charlie.Benefits
Test plan