Skip to content

Fix matchSubdomain function to correctly handle exact domain matches #2802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

suwakei
Copy link

@suwakei suwakei commented Jul 14, 2025

Problem

The matchSubdomain function incorrectly returns false for exact domain matches without wildcards—for example, http://example.com vs. http://example.com.

Cause

Even if all parts match during iteration, the function still returns false at the end.

Fix

After the loop, if all parts match and the number of parts is equal between the pattern and the domain, it should return true—i.e., treat it as an exact match.

This PR adds that check.

@suwakei
Copy link
Author

suwakei commented Jul 16, 2025

Hi! Just following up to see if there's anything I can improve in this PR 🙇

@FrancoTampieri
Copy link

My two cents:
I think the only think is missed the specific test for that case in util_test.go

@suwakei
Copy link
Author

suwakei commented Jul 16, 2025

I added specific unit test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants