Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,16 @@ function parseCSV(text) {
return rows.map(row => row.split(COMMA_PATTERN).map(cell => cell.trim()));
}

module.exports = { parseCSV };
function parseAPIResponse(responseBody, notifyError) {
if (typeof responseBody !== 'string' || responseBody.trim() === '') {
const message = 'No CSV data was returned. Please try again later.';
if (typeof notifyError === 'function') {
notifyError(message);
}
return [];
}

return parseCSV(responseBody);
}

module.exports = { parseCSV, parseAPIResponse };
22 changes: 21 additions & 1 deletion test/parser.test.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const { parseCSV } = require('../src/parser');
const { parseAPIResponse, parseCSV } = require('../src/parser');

let passed = 0;
let failed = 0;
Expand Down Expand Up @@ -59,5 +59,25 @@ let threwError = false;
try { parseCSV(''); } catch (e) { threwError = true; }
assert('throws on empty input', threwError, true);

// Test 7: Empty API responses show a friendly error instead of throwing
let errorToast = '';
assert(
'handles empty API response body with a friendly error',
parseAPIResponse(undefined, message => { errorToast = message; }),
[]
);
assert(
'reports friendly empty response error',
errorToast,
'No CSV data was returned. Please try again later.'
);

// Test 8: Non-empty API responses still parse as CSV
assert(
'parses non-empty API response body',
parseAPIResponse('name,age\nAda,36'),
[['name', 'age'], ['Ada', '36']]
);

console.log(`\n📊 Results: ${passed} passed, ${failed} failed\n`);
process.exit(failed > 0 ? 1 : 0);