Skip to content

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Jul 24, 2025

Adjusted responsive column breakpoints for VFolderNodeListPage

This PR adjusts the responsive column breakpoints in the VFolderNodeListPage component to improve the layout across different screen sizes:

  • Changed first column from lg={8} xxl={4} to md={8} lg={4}
  • Changed second column from lg={16} xxl={8} to md={16} lg={8}
  • Changed third column from xxl={12} to lg={12}

These changes allow the layout to respond better at medium screen sizes and create a more balanced distribution of space across different viewport widths.

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@Copilot Copilot AI review requested due to automatic review settings July 24, 2025 07:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue FR-1285 by adjusting the responsive grid layout to prevent the StorageStatusPanel from being too large on different screen sizes. The changes modify the column breakpoints for a better responsive behavior.

  • Updates grid breakpoints from lg and xxl to include md breakpoints for better medium screen sizing
  • Adjusts column spans across different breakpoints to optimize layout proportions
  • Ensures the StorageStatusPanel (third column) appears at appropriate sizes on large screens

@github-actions github-actions bot added the size:XS ~10 LoC label Jul 24, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Jul 24, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 4.82% 530/11004
🔴 Branches 3.91% 303/7742
🔴 Functions 2.79% 97/3471
🔴 Lines 4.78% 515/10767

Test suite run success

158 tests passing in 15 suites.

Report generated by 🧪jest coverage report action from 1664389

@agatha197 agatha197 force-pushed the fix_FR-1285_/storage-status-panel-card-too-large branch from 63b641e to 1664389 Compare August 4, 2025 02:19
Copy link
Contributor

@nowgnuesLee nowgnuesLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2025-08-06 at 13.38.21@2x.png

I think it gets squished too much, wouldn't the xl be better than the lg?

Copy link
Contributor Author

@nowgnuesLee Thank you for reviewing. But it is already resolved in main branch. close this PR.

@agatha197 agatha197 closed this Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants