Skip to content

feat(FR-1037): make ImageList paginatable using ImageNode #3721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nowgnuesLee
Copy link
Contributor

@nowgnuesLee nowgnuesLee commented May 27, 2025

resolves #3716 (FR-1037)

Replace ImageList with ImageNode in that PR to apply filter and order option. Requires 25.11 version of core

CleanShot 2025-07-02 at 18.29.35@2x.png

changes

  • add extraOptions prop to ProjectSelect copmonent.
  • Updated GraphQL schema to support service configuration management
  • Fixed AuditLogNode field descriptions and types
  • Added installed field to ImageNode to indicate if image is installed on any Agent
  • Renamed MetircResultValue to MetricResultValue (fixing typo)
  • Updated value_type descriptions and defaults in UserUtilizationMetricQueryInput
  • Added new service-related GraphQL types and queries
  • Implemented new ImageList component using ImageNode with pagination support
  • Preserved old ImageList as ImageListBefore202506 for backward compatibility
  • Updated ManageAppsModal and ManageImageResourceLimitModal to work with ImageNode
  • Added filter capabilities with BAIPropertyFilter for image filtering
  • Added project selection to filter images by project
  • Using NEO style BAITable for better UI consistency

Copy link
Contributor Author

nowgnuesLee commented May 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the size:XL 500~ LoC label May 27, 2025
@nowgnuesLee nowgnuesLee changed the title feat(FR-1037): make ImageList to be paginationable feat(FR-1037): make ImageList paginatable using ImageNode May 27, 2025
@nowgnuesLee nowgnuesLee force-pushed the feat/image-list-pagination branch 4 times, most recently from 9b802dd to 2559439 Compare June 2, 2025 08:06
@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization labels Jun 2, 2025
@nowgnuesLee nowgnuesLee force-pushed the feat/image-list-pagination branch from 2559439 to e495e90 Compare June 4, 2025 06:49
@nowgnuesLee nowgnuesLee force-pushed the feat/image-list-pagination branch 2 times, most recently from ec779ae to 84eff31 Compare June 24, 2025 02:06
Copy link

github-actions bot commented Jun 24, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.44% (-0.08% 🔻)
492/11079
🔴 Branches
3.96% (-0.07% 🔻)
306/7728
🔴 Functions
2.57% (-0.06% 🔻)
91/3534
🔴 Lines
4.4% (-0.08% 🔻)
477/10836
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / ManageAppsModalBefore251100.tsx
0% 0% 0% 0%
🔴
... / ManageImageResourceLimitModalBefore251100.tsx
0% 0% 0% 0%
🔴
... / ImageListBefore251100.tsx
0% 0% 0% 0%

Test suite run success

159 tests passing in 15 suites.

Report generated by 🧪jest coverage report action from d197110

@nowgnuesLee nowgnuesLee force-pushed the feat/image-list-pagination branch 7 times, most recently from e6be079 to 89fc662 Compare July 1, 2025 05:01
@nowgnuesLee nowgnuesLee changed the base branch from main to graphite-base/3721 July 1, 2025 06:31
@nowgnuesLee nowgnuesLee force-pushed the feat/image-list-pagination branch from 89fc662 to 2320eca Compare July 1, 2025 06:32
@nowgnuesLee nowgnuesLee changed the base branch from graphite-base/3721 to fix/BAITable-controll-pagination July 1, 2025 06:32
@nowgnuesLee nowgnuesLee force-pushed the feat/image-list-pagination branch from 2320eca to e54f8ca Compare July 1, 2025 06:35
@nowgnuesLee nowgnuesLee marked this pull request as ready for review July 1, 2025 06:42
@nowgnuesLee nowgnuesLee force-pushed the feat/image-list-pagination branch from 9f1d99e to 5c5d38b Compare July 2, 2025 09:31
@nowgnuesLee nowgnuesLee force-pushed the feat/image-list-pagination branch from 5c5d38b to e412bc9 Compare July 4, 2025 07:15
@github-actions github-actions bot added the area:lib Library and SDK related issue. label Jul 4, 2025
@nowgnuesLee nowgnuesLee requested a review from ironAiken2 July 4, 2025 07:16
@nowgnuesLee nowgnuesLee force-pushed the feat/image-list-pagination branch 2 times, most recently from 576733c to 19becd2 Compare July 7, 2025 01:50
@nowgnuesLee nowgnuesLee requested a review from ironAiken2 July 7, 2025 01:51
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. It would be better to relocate name filter to the first.
  2. select some rows -> click refresh button -> initialize selection. please keep them.
  3. set the width to namespace and tag column. if you select another page and page refresh, the width of two columns is changed.
  4. unify control button size. (agent list use large size. please check again which is correct).
  5. please add tooltip to control buttons.
  6. Please set showSorterTooltip={false}. you can modify BAITable.
    image.png

@nowgnuesLee nowgnuesLee force-pushed the feat/image-list-pagination branch from 19becd2 to 5636115 Compare July 7, 2025 05:09
Copy link
Contributor Author

  1. I'll fix it.
  2. I'll fix it.
  3. I'll fix it.
  4. large size is wrong. I'll fix it.
  5. I'll add it.
  6. I'll fix it.

@nowgnuesLee nowgnuesLee force-pushed the feat/image-list-pagination branch from 5636115 to 19ee2cb Compare July 7, 2025 05:31
Copy link
Contributor Author

  1. I'll fix it in another pr @agatha197

@nowgnuesLee nowgnuesLee force-pushed the feat/image-list-pagination branch 2 times, most recently from da0f03f to 5ab0dbb Compare July 7, 2025 05:57
@nowgnuesLee nowgnuesLee requested a review from agatha197 July 7, 2025 06:56
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

select items on different page -> click refresh button -> selected items are initialized.

oh never mind. this is only before 25.11.0

@nowgnuesLee nowgnuesLee force-pushed the feat/image-list-pagination branch from 5ab0dbb to c085c91 Compare July 8, 2025 06:30
@nowgnuesLee nowgnuesLee requested a review from agatha197 July 8, 2025 06:31
@nowgnuesLee nowgnuesLee force-pushed the feat/image-list-pagination branch from c085c91 to c54882c Compare July 15, 2025 08:46
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

select all items -> move next page -> select all items: removed first selected rows.

@nowgnuesLee nowgnuesLee force-pushed the feat/image-list-pagination branch from c54882c to 91e4919 Compare July 16, 2025 04:21
@nowgnuesLee nowgnuesLee requested a review from agatha197 July 16, 2025 04:25
@yomybaby yomybaby force-pushed the feat/image-list-pagination branch from 91e4919 to d197110 Compare July 17, 2025 07:07
@yomybaby yomybaby marked this pull request as draft July 17, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:lib Library and SDK related issue. area:ux UI / UX issue. size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ImageNode in image list page
4 participants