-
Notifications
You must be signed in to change notification settings - Fork 76
feat(FR-1037): make ImageList paginatable using ImageNode #3721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
9b802dd
to
2559439
Compare
2559439
to
e495e90
Compare
ec779ae
to
84eff31
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 4.44% (-0.08% 🔻) |
492/11079 |
🔴 | Branches | 3.96% (-0.07% 🔻) |
306/7728 |
🔴 | Functions | 2.57% (-0.06% 🔻) |
91/3534 |
🔴 | Lines | 4.4% (-0.08% 🔻) |
477/10836 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🔴 | ... / ManageAppsModalBefore251100.tsx |
0% | 0% | 0% | 0% |
🔴 | ... / ManageImageResourceLimitModalBefore251100.tsx |
0% | 0% | 0% | 0% |
🔴 | ... / ImageListBefore251100.tsx |
0% | 0% | 0% | 0% |
Test suite run success
159 tests passing in 15 suites.
Report generated by 🧪jest coverage report action from d197110
e6be079
to
89fc662
Compare
89fc662
to
2320eca
Compare
2320eca
to
e54f8ca
Compare
9f1d99e
to
5c5d38b
Compare
5c5d38b
to
e412bc9
Compare
576733c
to
19becd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It would be better to relocate name filter to the first.
- select some rows -> click refresh button -> initialize selection. please keep them.
- set the width to namespace and tag column. if you select another page and page refresh, the width of two columns is changed.
- unify control button size. (agent list use large size. please check again which is correct).
- please add tooltip to control buttons.
- Please set
showSorterTooltip={false}
. you can modify BAITable.
19becd2
to
5636115
Compare
|
5636115
to
19ee2cb
Compare
|
da0f03f
to
5ab0dbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
select items on different page -> click refresh button -> selected items are initialized.
oh never mind. this is only before 25.11.0
5ab0dbb
to
c085c91
Compare
c085c91
to
c54882c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
select all items -> move next page -> select all items: removed first selected rows.
c54882c
to
91e4919
Compare
91e4919
to
d197110
Compare
resolves #3716 (FR-1037)
Replace
ImageList
withImageNode
in that PR to apply filter and order option. Requires25.11
version of corechanges
extraOptions
prop toProjectSelect
copmonent.installed
field to ImageNode to indicate if image is installed on any AgentMetircResultValue
toMetricResultValue
(fixing typo)